Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flag --incompatible_disable_starlark_host_transitions will break stardoc in Bazel 7.0 #145

Closed
keertk opened this issue Dec 16, 2022 · 4 comments · Fixed by #179
Closed
Assignees

Comments

@keertk
Copy link
Member

keertk commented Dec 16, 2022

Incompatible flag --incompatible_disable_starlark_host_transitions will be enabled by default in the next major release (Bazel 7.0), thus breaking stardoc. Please migrate to fix this and unblock the flip of this flag.

The flag is documented here: bazelbuild/bazel#17032.

Please check the following CI builds for build and test results:

Never heard of incompatible flags before? We have documentation that explains everything.
If you have any questions, please file an issue in https://github.com/bazelbuild/continuous-integration.

@sgowroji
Copy link
Member

Hi Team, Gentle ping , Can you share any significant update on this issue. Thanks!

@tetromino
Copy link
Collaborator

We are not using host transitions in Stardoc itself - but it's used by many of our deps (skylib, rules_license, rules_jvm_external, rules_cc).

We should check whether those projects have releases which work with --incompatible_disable_starlark_host_transitions (for skylib e.g. we need to update to 1.4.1).

@tetromino
Copy link
Collaborator

We're blocked by Bazel itself using host transitions in third_party/grpc/build_defs.bzl :)

ERROR: Traceback (most recent call last):
	File "/private/var/tmp/_bazel_arostovtsev/4db74ff3612d0bdc1259d9a6e5cd2136/external/io_bazel/third_party/grpc/build_defs.bzl", line 64, column 30, in <toplevel>
		"_protoc": attr.label(
Error in label: 'cfg = "host"' is deprecated and should no longer be used. Please use 'cfg = "exec"' instead.
ERROR: /private/var/tmp/_bazel_arostovtsev/4db74ff3612d0bdc1259d9a6e5cd2136/external/io_bazel/src/main/java/com/google/devtools/build/lib/collect/nestedset/BUILD:16:13: error loading package '@io_bazel//src/main/protobuf': initialization of module 'third_party/grpc/build_defs.bzl' failed and referenced by '@io_bazel//src/main/java/com/google/devtools/build/lib/collect/nestedset:nestedset'

@tetromino tetromino added P3 and removed P2 labels Jun 27, 2023
tetromino added a commit to tetromino/bazel that referenced this issue Aug 7, 2023
Removes a blocker for buildimg Bazel itself with --incompatible_disable_starlark_host_transition -
and unblocks bazelbuild/stardoc#145
@tetromino
Copy link
Collaborator

Steps to fix:

copybara-service bot pushed a commit to bazelbuild/bazel that referenced this issue Aug 8, 2023
Removes a blocker for buildimg Bazel itself with --incompatible_disable_starlark_host_transition -
and unblocks bazelbuild/stardoc#145

Partial commit for third_party/*, see #19192.

Signed-off-by: Pavan Singh <[email protected]>
tetromino added a commit that referenced this issue Aug 8, 2023
…t_transitions (#179)

And to make sure we stay unbroken, add the flag to our ci config - which on Windows requires setting `BAZELISK_SHUTDOWN=1` to work around bazelbuild/continuous-integration#1012

Fixes #145
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants