Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename cc_common_internal_do_not_use back to cc_common #18849

Closed
wants to merge 2 commits into from

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Jul 6, 2023

The name of CcModule is shown in Bazel docs and should match the name of the top-level cc_common built-in symbol.

@fmeum fmeum marked this pull request as ready for review July 6, 2023 10:41
@fmeum fmeum requested a review from oquenchil as a code owner July 6, 2023 10:41
@fmeum fmeum requested review from buildbreaker2021 and removed request for oquenchil July 6, 2023 10:41
@github-actions github-actions bot added awaiting-review PR is awaiting review from an assigned reviewer team-Rules-CPP Issues for C++ rules labels Jul 6, 2023
@fmeum
Copy link
Collaborator Author

fmeum commented Jul 6, 2023

@buildbreaker2021 The original report was https://bazelbuild.slack.com/archives/CGA9QFQ8H/p1688479868511049. I am not sure I fully understand how the built-in private API restrictions work, but this does seem to pass all tests while not exposing private API.

@buildbreaker2021
Copy link
Contributor

I am trying to remember why I named this cc_common_internal_do_not_use - maybe because of naming conflicts. But this could have just been my assumption that there would be a conflict. I will check the history and will provide the review.

@buildbreaker2021 buildbreaker2021 self-assigned this Jul 12, 2023
@fmeum
Copy link
Collaborator Author

fmeum commented Jul 12, 2023

@buildbreaker2021 I looked into how java_common is doing this and found that it is not using a different name. My thinking was that every context (builtins vs non-builtins) would only ever see a single instance of the cc_common top-level symbol.

@buildbreaker2021
Copy link
Contributor

Yeah I also did not find a compelling reason for why I've named it that way.

@github-actions github-actions bot removed the awaiting-review PR is awaiting review from an assigned reviewer label Jul 12, 2023
@fmeum fmeum deleted the fix-cc-common branch July 12, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Rules-CPP Issues for C++ rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants