Skip to content

Implement additional safety checks for DisputeGameFactory upgrade #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Implement additional safety checks for DisputeGameFactory upgrade #275

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 41 additions & 0 deletions setup-templates/template-upgrade-fault-proofs/script/UpgradeDGF.s.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,26 @@ contract UpgradeDGF is NestedMultisigBuilder {
_precheckDisputeGameImplementation(GameTypes.CANNON, fdgImpl);
_precheckDisputeGameImplementation(GameTypes.PERMISSIONED_CANNON, pdgImpl);
// TODO: Add extra pre-checks here

// Verify that the new implementations are contracts
require(fdgImpl.code.length > 0, "FDG implementation is not a contract");
require(pdgImpl.code.length > 0, "PDG implementation is not a contract");

// Verify that the owner of the DGF is correct
require(dgfProxy.owner() == _OWNER_SAFE, "DGF owner mismatch");

// Verify that the new implementations have the correct interfaces
try FaultDisputeGame(fdgImpl).gameType() returns (GameType gameType) {
require(gameType.raw() == GameTypes.CANNON.raw(), "FDG implementation has incorrect game type");
} catch {
revert("FDG implementation does not implement gameType()");
}

try PermissionedDisputeGame(pdgImpl).gameType() returns (GameType gameType) {
require(gameType.raw() == GameTypes.PERMISSIONED_CANNON.raw(), "PDG implementation has incorrect game type");
} catch {
revert("PDG implementation does not implement gameType()");
}
}

// Checks that the new game being set has the same configuration as the existing implementation with the exception
Expand Down Expand Up @@ -84,6 +104,27 @@ contract UpgradeDGF is NestedMultisigBuilder {
_postcheckHasAnchorState(GameTypes.CANNON);
_postcheckHasAnchorState(GameTypes.PERMISSIONED_CANNON);
// TODO: Add extra post-checks here

// Verify that the implementations can be initialized correctly
FaultDisputeGame cannonImpl = FaultDisputeGame(address(dgfProxy.gameImpls(GameTypes.CANNON)));
FaultDisputeGame permissionedImpl = FaultDisputeGame(address(dgfProxy.gameImpls(GameTypes.PERMISSIONED_CANNON)));

// Check that the implementations are initialized and ready to create games
require(cannonImpl.gameType().raw() == GameTypes.CANNON.raw(), "post-200");
require(permissionedImpl.gameType().raw() == GameTypes.PERMISSIONED_CANNON.raw(), "post-210");

// Verify that the factory can create games with the new implementations
try dgfProxy.gameCount(GameTypes.CANNON) returns (uint256 count) {
console.log("Current CANNON game count:", count);
} catch {
revert("Failed to get CANNON game count");
}

try dgfProxy.gameCount(GameTypes.PERMISSIONED_CANNON) returns (uint256 count) {
console.log("Current PERMISSIONED_CANNON game count:", count);
} catch {
revert("Failed to get PERMISSIONED_CANNON game count");
}
}

// Checks the anchor state for the source game type still exists after re-initialization. The actual anchor state
Expand Down