Skip to content

Implement additional safety checks for DisputeGameFactory upgrade #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Implement additional safety checks for DisputeGameFactory upgrade #275

wants to merge 1 commit into from

Conversation

DeVikingMark
Copy link

Implements TODO items in UpgradeDGF.s.sol by adding:

Pre-checks:

  • Verify implementations are contracts
  • Verify DGF owner is correct
  • Verify implementations have correct interfaces

Post-checks:

  • Verify implementations are properly initialized
  • Verify factory can interact with new implementations
  • Log game counts for monitoring

These changes improve safety of the DisputeGameFactory upgrade process.

@cb-heimdall
Copy link
Collaborator

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@wbnns wbnns added the base protocol review To be reviewed by the Base web team label Apr 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
base protocol review To be reviewed by the Base web team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DeVikingMark @cb-heimdall @wbnns