Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update deps to support OpenSSL v3+ #111

Merged
merged 2 commits into from
Sep 6, 2022
Merged

update deps to support OpenSSL v3+ #111

merged 2 commits into from
Sep 6, 2022

Conversation

calebcartwright
Copy link
Member

I've updated to an OS version which utilizes OpenSSL v3, and we'll run into the same whenever we get back around to the updates needed for #78.

In the interim, I'd like to go ahead and update some of our transitive dependencies to newer versions which bring support for OpenSSL v3. Note that I've tested this locally for emoji compatibility out of an abundance of caution, and as expected this does not introduce any emoji related issues.

@calebcartwright calebcartwright added the dependencies Related to dependency updates label Sep 5, 2022
@shields-cd shields-cd temporarily deployed to squint-pr-111 September 5, 2022 18:29 Inactive
@chris48s
Copy link
Member

chris48s commented Sep 5, 2022

Sounds reasonable. Surprisingly though, updating these does appear to introduce some lint errors though.

@shields-cd shields-cd temporarily deployed to squint-pr-111 September 6, 2022 00:34 Inactive
@calebcartwright
Copy link
Member Author

calebcartwright commented Sep 6, 2022

Sounds reasonable. Surprisingly though, updating these does appear to introduce some lint errors though.

I think it's unrelated and suspect it's just the first build we've had in a while that compiled successfully and allowed the lint stage to run with the latest Rust (our CI is currently live streaming the latest Rust release, which is on a ~6 week release cycle) which includes some enhancements allowing for better lint detection

@chris48s
Copy link
Member

chris48s commented Sep 6, 2022

ah that makes sense - I couldn't see anything in the updated dependencies that looked like it would affect linting

@calebcartwright calebcartwright merged commit 804128d into main Sep 6, 2022
@calebcartwright calebcartwright deleted the openssl3 branch September 6, 2022 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Related to dependency updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants