Restore or replace Heroku Review Apps

[chris48s]

📋 Description

Until https://status.heroku.com/incidents/2413 happened we were using Heroku review apps to build a preview site for each PR. This was a big help for reviewing contributions and dependency bumps.

The latest update from Heroku is

For the protection of our customers, we will not be reconnecting to GitHub until we are certain that we can do so safely, which may take some time. We recommend that customers use alternate methods rather than waiting for us to restore this integration.

The simplest approach to deploy Heroku apps is directly using git push heroku main. Alternatively, you can refer to one of the add-ons listed in the Continuous Integration and Delivery section of the Heroku Ecosystem Marketplace or other third party CI/CD products that offer Heroku support, such as Circle CI. You can also use community-maintained integrations such as this GitHub Action for deploying to Heroku.

We sincerely regret any inconvenience you may have experienced because of this issue and appreciate your trust in us as we continue to make your success our top priority. Please continue to visit status.heroku.com for the latest updates.

The key phrase there for me is:

We recommend that customers use alternate methods rather than waiting for us to restore this integration

Investigate how we could re-enable review apps, either using Heroku via some other avenue or by migrating away from Heroku. One possible thing we could look at is https://github.com/superfly/fly-pr-review-apps

[calebcartwright]

One of the challenges I think we'd run into with the Fly review apps model is that it's predicated on having a GitHub Actions secret available, but those are disabled and unavailable on PRs coming from forks for security reasons

[calebcartwright]

https://blog.heroku.com/github-integration-update (some progress but still not resolved)

[chris48s]

Good find and good point about the fly review apps. I think in the short term re-enabling Heroku review apps when they enable github deploys again is probably the play.

@SnoozeThis wait until May 26 2022

[SnoozeThis]

(https://snoozeth.is/X6ov_cwqaA8) I will wait until Thu, 26 May 2022 00:00:00 UTC and then add a comment.

[SnoozeThis]

Resolved.

[chris48s]

https://blog.heroku.com/github-integration-update

[chris48s]

partially done in

#8213 (comment)

but not really

[calebcartwright]

I know we've discussed already, but it continues to surprise me that the review apps for squint just continue to work while the ones for shields are all out of whack 🤷‍♂️ (e.g. badges/squint#111)

[chris48s]

Presumably we also had to re-connect the squint ones after the long heroku security outage. I wonder if we did anything differently?

[calebcartwright]

That's the thing, I didn't. Squint just started working

[chris48s]

Haunted. No other explanation.

[calebcartwright]

👻

[chris48s]

Looks like our review apps are now failing with code=H82 desc="Free app running time quota exhausted"