Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support bulk deposit/withdraw and ERC1155 #4

Open
wants to merge 2 commits into
base: mainnet
Choose a base branch
from

Conversation

minh-bq
Copy link

@minh-bq minh-bq commented Dec 20, 2023

Description

This PR adds

  • Support for batching multiple deposits and withdrawal signature submission requests in a transaction in MainchainGateway. For batching multiple withdrawal submission requests, RoninGateway already supports it via bulkRequestWithdrawalFor function.
  • Support for ERC1155 token deposit/withdrawal

This also changes some abi.encodeWithSelector to abi.encodeCall to make the compiler type check the arguments.

Checklist

  • I have clearly commented on all the main functions following the NatSpec Format
  • The box that allows repo maintainers to update this PR is checked
  • I tested locally to make sure this feature/fix works

This commit adds functions to batch multiple deposits and withdrawal signature
submission requests in a transaction in MainchainGateway. For batching multiple
withdrawal submission requests, RoninGateway already supports it via
bulkRequestWithdrawalFor function.
This commit supports ERC1155 token deposit/withdrawal via bridge. It also
changes some abi.encodeWithSelector to abi.encodeCall to make the compiler type
check the arguments.
nxqbao added a commit that referenced this pull request Mar 6, 2024
…dress

fix(BridgeManager): disable update operator
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant