Skip to content

Commit d9ae1e3

Browse files
authored
Merge pull request #4 from ronin-chain/fix/disable-change-operator-address
fix(BridgeManager): disable update operator
2 parents 1be539e + dbc7db4 commit d9ae1e3

File tree

2 files changed

+2
-25
lines changed

2 files changed

+2
-25
lines changed

src/extensions/bridge-operator-governance/BridgeManager.sol

Lines changed: 1 addition & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -118,31 +118,7 @@ abstract contract BridgeManager is IQuorum, IBridgeManager, BridgeManagerCallbac
118118
* their operator address blank null `address(0)`, consider add authorization check.
119119
*/
120120
function updateBridgeOperator(address newBridgeOperator) external onlyGovernor {
121-
_requireNonZeroAddress(newBridgeOperator);
122-
123-
// Queries the previous bridge operator
124-
mapping(address => BridgeOperatorInfo) storage _gorvernorToBridgeOperatorInfo = _getGovernorToBridgeOperatorInfo();
125-
address currentBridgeOperator = _gorvernorToBridgeOperatorInfo[msg.sender].addr;
126-
if (currentBridgeOperator == newBridgeOperator) {
127-
revert ErrBridgeOperatorAlreadyExisted(newBridgeOperator);
128-
}
129-
130-
// Tries replace the bridge operator
131-
EnumerableSet.AddressSet storage _bridgeOperatorSet = _getBridgeOperatorSet();
132-
bool updated = _bridgeOperatorSet.remove(currentBridgeOperator) && _bridgeOperatorSet.add(newBridgeOperator);
133-
if (!updated) revert ErrBridgeOperatorUpdateFailed(newBridgeOperator);
134-
135-
mapping(address => address) storage _governorOf = _getGovernorOf();
136-
delete _governorOf[currentBridgeOperator];
137-
_governorOf[newBridgeOperator] = msg.sender;
138-
_gorvernorToBridgeOperatorInfo[msg.sender].addr = newBridgeOperator;
139-
140-
_notifyRegisters(
141-
IBridgeManagerCallback.onBridgeOperatorUpdated.selector,
142-
abi.encode(currentBridgeOperator, newBridgeOperator)
143-
);
144-
145-
emit BridgeOperatorUpdated(msg.sender, currentBridgeOperator, newBridgeOperator);
121+
revert("Not supported");
146122
}
147123

148124
/**

test/bridge/unit/fuzz/bridge-manager/BridgeManagerCRUD.t.sol

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -212,6 +212,7 @@ contract BridgeManagerCRUDTest is BridgeManagerUtils {
212212
uint256 r3,
213213
uint16 numBridgeOperators
214214
) external virtual {
215+
vm.skip(true);
215216
(address[] memory bridgeOperators, address[] memory governors, uint96[] memory voteWeights) = getValidInputs(
216217
r1,
217218
r2,

0 commit comments

Comments
 (0)