fix: flaky fs test #4391
Merged
fix: flaky fs test #4391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkomonen-amazon
force-pushed
the
fixFlakyTest
branch
from
95b6cb1 to
fcef50f
Compare
|
/retryBuilds |
justinmk3
reviewed
Feb 5, 2024
justinmk3
approved these changes
Feb 5, 2024
|
/retryBuilds |
nkomonen-amazon
force-pushed
the
fixFlakyTest
branch
2 times, most recently
from
c7a1231 to
22761e1
Compare
Reported by aws#4390, this test is failing on the mkdirSpy call count assertion. Not exactly sure why this is flaky, but maybe it is due to the previous folders not being cleaned up. This commit deletes the created folders after each test finishes. Additionally, this commit checks the actual spy call count so that we can better debug the issue Signed-off-by: nkomonen <[email protected]>
nkomonen-amazon
force-pushed
the
fixFlakyTest
branch
from
22761e1 to
edb707d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported by #4390, this test is failing on the mkdirSpy call count assertion.
Not exactly sure why this is flaky, but maybe it is due to the previous folders not being cleaned up.
Solution
This commit deletes the created folders after each test finishes. Additionally, this commit checks the actual spy call count so that we can better debug the issue
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.