fix: flaky fs test

Reported by #4390, this test is failing on the mkdirSpy call count assertion.

Not exactly sure why this is flaky, but maybe it is due
to the previous folders not being cleaned up.

This commit deletes the created folders after each test finishes.
Additionally, this commit checks the actual spy call count so that
we can better debug the issue

Signed-off-by: nkomonen <[email protected]>

packages/toolkit/src/test/srcShared/fs.test.ts

@@ -24,6 +24,7 @@ describe('FileSystem', function () {
 
     before(async function () {
         fakeContext = await FakeExtensionContext.create()
+        await deleteTestRoot() // incase a previous test run failed to clean
     })
 
     beforeEach(async function () {
@@ -161,7 +162,7 @@ describe('FileSystem', function () {
             it(`creates folder: '${p}'`, async function () {
                 const dirPath = createTestPath(p)
                 await fsCommon.mkdir(dirPath)
-                assert.ok(existsSync(dirPath))
+                assert(existsSync(dirPath))
             })
         })
 
@@ -173,8 +174,8 @@ describe('FileSystem', function () {
 
                 await fsCommon.mkdir(dirPath)
 
-                assert.ok(existsSync(dirPath))
-                assert.ok(mkdirSpy.calledOnce)
+                assert(existsSync(dirPath))
+                assert.strictEqual(mkdirSpy.callCount, 1)
             })
         })
     })
@@ -300,14 +301,14 @@ describe('FileSystem', function () {
     }
 
     function testRootPath() {
-        return path.join(fakeContext.globalStorageUri.fsPath, 'testDir')
+        return path.join(fakeContext.globalStorageUri.fsPath, 'fsTestDir')
     }
 
     async function makeTestRoot() {
         return mkdirSync(testRootPath())
     }
 
     async function deleteTestRoot() {
-        return rmSync(testRootPath(), { recursive: true })
+        rmSync(testRootPath(), { recursive: true, force: true })
     }
 })