Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: cleanup script cb #13161

Merged
merged 7 commits into from
Aug 28, 2023
Merged

ci: cleanup script cb #13161

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d58147e
chore: codebuild cleanup script
goldbez Jul 21, 2023
12063da
chore: codebuild cleanup script
goldbez Jul 21, 2023
994f66f
chore: codebuild cleanup script
goldbez Jul 21, 2023
413efc0
chore: codebuild cleanup script
goldbez Jul 21, 2023
a74262a
chore: codebuild cleanup script
goldbez Jul 22, 2023
ca676be
chore: codebuild cleanup script
goldbez Jul 22, 2023
7ed7929
Merge branch 'dev' into cb_cleanup_4
awsluja Aug 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions codebuild_specs/aggregate_e2e_reports.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,13 @@ phases:
- ts-node ./wait-for-all-codebuild.ts $CODEBUILD_RESOLVED_SOURCE_VERSION ../$WAIT_FOR_IDS_FILE_PATH $PROJECT_NAME
- cd ..
- source ./shared-scripts.sh && _downloadReportsFromS3 $CODEBUILD_SOURCE_VERSION
- mkdir artifacts && echo "empty artifact" > artifacts/empty-artifact.txt
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needed for cleanup script or just an unrelated change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just needed any artifact, as the cleanup job depends on the aggregate job to finish; Codebuild requires 'some' file to be produced in order to depend on a job

reports:
e2e-reports:
files:
- '*.xml'
file-format: 'JUNITXML'
base-directory: '$CODEBUILD_SRC_DIR/aggregate_reports'
artifacts:
files:
- 'artifacts/*'
3 changes: 2 additions & 1 deletion codebuild_specs/cleanup_resources.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@ env:
phases:
build:
commands:
- echo cleanup running
- npm install -g ts-node
- source ./shared-scripts.sh && _cleanUpResources
artifacts:
files:
- 'shared-scripts.sh'
4 changes: 4 additions & 0 deletions codebuild_specs/e2e_workflow_base.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,3 +136,7 @@ batch:
compute-type: BUILD_GENERAL1_LARGE
depend-on:
- upb
- identifier: cleanup_resources
buildspec: codebuild_specs/cleanup_resources.yml
depend-on:
- aggregate_e2e_reports
Loading