ci: cleanup script cb #13161
Merged
ci: cleanup script cb #13161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolk
approved these changes
Aug 28, 2023
Amplifiyer
approved these changes
Aug 28, 2023
| @@ -10,9 +10,13 @@ phases: | |||
| - ts-node ./wait-for-all-codebuild.ts $CODEBUILD_RESOLVED_SOURCE_VERSION ../$WAIT_FOR_IDS_FILE_PATH $PROJECT_NAME | |||
| - cd .. | |||
| - source ./shared-scripts.sh && _downloadReportsFromS3 $CODEBUILD_SOURCE_VERSION | |||
| - mkdir artifacts && echo "empty artifact" > artifacts/empty-artifact.txt | |||
There was a problem hiding this comment.
Is this needed for cleanup script or just an unrelated change?
There was a problem hiding this comment.
just needed any artifact, as the cleanup job depends on the aggregate job to finish; Codebuild requires 'some' file to be produced in order to depend on a job
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Cleanup script for Codebuild which focuses on stale resources, by @goldbez .
In short, this just runs the cleanup script without any parameters, so that it scans through each e2e test account and deletes old resources.
Successful run here https://tiny.amazon.com/kyjz1b29/IsenLink
Issue #, if available
Description of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.