E2e refactor separate suites #592
Conversation
cam-schultz
requested review from
iansuvak,
geoff-vball,
bernard-avalabs and
michaelkaplan13
scripts/local/e2e_test.sh
Outdated
| printUsage | ||
| } | ||
|
|
||
| valid_components="teleporter governance validator-manager" |
There was a problem hiding this comment.
If we just test for the existence of ./tests/local//$component/$component.test, then we don't have to maintain this list.
| } | ||
|
|
||
| // Define the Teleporter before and after suite functions. | ||
| var _ = ginkgo.BeforeSuite(func() { |
There was a problem hiding this comment.
Is this setup the same for all the suites? Can we extract this function out somewhere common?
There was a problem hiding this comment.
The only difference is that governance and validator-manager suites omit setting up Teleporter. I'm open to suggestions, but IMO the set of network setup functions are sufficiently modular to cover our test cases.
There was a problem hiding this comment.
Sorry - got my wires crossed. This WIP branch makes the change I described. With it, the governance and validator-manager suites have no dependency on the Teleporter contracts
scripts/local/e2e_test.sh
Outdated
| valid_components="teleporter governance validator-manager" | ||
|
|
There was a problem hiding this comment.
We still reference valid_components on line 21. We should probably just ls ./tests/local/ to give a list of valid components.
There was a problem hiding this comment.
I just removed the variable containing valid components altogether to simplify things.
scripts/local/e2e_test.sh
Outdated
| function printUsage() { | ||
| cat << EOF | ||
| Arguments: | ||
| --component <component> Component test suite to run. Must be a valid directory in tests/local/ |
There was a problem hiding this comment.
Love the change to be able to only test the component that changed but should we still have the ability to run all of them easily?
I'm thinking it might be worthwhile locally and maybe on merge to master which would be a good sanity check and be rarer than each PR commit push
There was a problem hiding this comment.
For CI, we should run the suites in parallel on separate runners in all scenarios for expediancy and isolation. The local use case makes sense though. I've modified the script to run all components by default if no argument is provided.
Why this should be merged
Following #591, updates the remaining validator manager e2e tests to use the full validator registration flow with the P-Chain.
How this works
teleporter,governance, andvalidator-manager. Each of these suites run in their own CI jobs.validator-managersuite test since they modify the underlying network topologyvalidator-managertests to reduce the overall e2e running timeerc20_delegation.goremoved; delegation logic moved toerc20_token_staking.gonative_delegation.goremoved; delegation logic moved tonative_token_staking.gopoa_validator_manager.goremoved; PoA owner checks moved topoa_to_pos.goHow this was tested
CI
How is this documented
N/A