Post-Etna ERC20 validator e2e #591
Conversation
cam-schultz
requested review from
iansuvak,
geoff-vball,
bernard-avalabs and
michaelkaplan13
| signatureAggregator, | ||
| utils.DefaultMinStakeAmount*10, | ||
| ) | ||
| // _ = utils.InitializeERC20TokenValidatorSet( |
There was a problem hiding this comment.
Why is this getting commented out?
There was a problem hiding this comment.
This is one of a series of PRs (#585 and #592) that touch individual parts of the contracts and testing components. Rather than getting each to pass CI individually, I elected to stub/comment out incompatible code. The final PR in the series has everything intact. The focus for this PR is really only erc20_staking.go
| Expect(err).Should(BeNil()) | ||
| } | ||
|
|
||
| // Sort the nodeIDs so that the subnet conversion ID matches the P-Chain |
There was a problem hiding this comment.
| // Sort the nodeIDs so that the subnet conversion ID matches the P-Chain | |
| // Sort the nodeIDs so that the Subnet conversion ID matches the P-Chain |
SECURITY.md
Outdated
| @@ -4,13 +4,13 @@ Avalanche takes the security of the platform and of its users very seriously. We | |||
|
|
|||
| ## Reporting a Vulnerability | |||
|
|
|||
| **Please do not file a public ticket** mentioning the vulnerability. To disclose a vulnerability submit it through our [Bug Bounty Program](https://hackenproof.com/avalanche). | |||
| **Please do not file a public ticket** mentioning the vulnerability. To disclose a vulnerability submit it through our [Bug Bounty Program](https://immunefi.com/bug-bounty/avalanche/information/). | |||
There was a problem hiding this comment.
I think this is already updated in main. Could we pull those commits in so to reduce the diff in this PR?
I think I goofed my branches somewhere along the line, sorry about that. For this PR, only |
|
I'm going to close this out and include the changes here in #592. I think that separating these changes resulted in more confusion than help. |
Why this should be merged
Implements the full validator registration flow post Etna for ERC20 PoSValidatorManagers
Review focus:
tests/flows/validator-manager/erc20_token_staking.goHow this works
Adds support for issuing P-Chain tx's. Converts the subnet to permissionless as part of the test flow.
This PR is NOT expected to pass CI. The main objective of this PR is to add the functionality needed to convert all tests to post-Etna validator management via the ValidatorManager contract. A following PR will implement that refactor.
How this was tested
How is this documented