Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docker): introduce autoware-base images #5476

Merged
merged 16 commits into from
Nov 25, 2024
Merged

Conversation

youtalk
Copy link
Member

@youtalk youtalk commented Nov 22, 2024

Description

To improve the efficiency of container builds and enhance readability in the Dockerfile, this PR is introducing the autoware-base images as the base image for the autoware images.
The autoware-base image is scheduled to be updated only once a month.

The resulting images will be as follows:
https://github.com/youtalk/autoware/pkgs/container/autoware-base

However, the autoware-base image has not yet been configured to be used for building the autoware image, so there are no side effects at this point. This will be implemented in the next PR.

Tests performed

https://github.com/youtalk/autoware/actions/runs/11971168497/job/33375410665

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

youtalk and others added 14 commits November 22, 2024 21:10
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
This reverts commit bb9f18a.
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
@youtalk youtalk marked this pull request as ready for review November 22, 2024 12:37
@youtalk youtalk self-assigned this Nov 22, 2024
@youtalk youtalk added type:containers Docker containers, containerization of components, or container orchestration. component:openadkit Issues or Features related to Open AD Kit tag:run-health-check Run health-check labels Nov 22, 2024
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 4 changed files in this pull request and generated 1 suggestion.

Files not reviewed (2)
  • docker/Dockerfile.base: Language not supported
  • docker/docker-bake-base.hcl: Language not supported
Comments skipped due to low confidence (1)

.github/actions/docker-build-and-push-base/action.yaml:30

  • The bake-target 'docker-metadata-action-base' is not defined in the provided diff. This might cause an error during execution.
bake-target: docker-metadata-action-base

Signed-off-by: Yutaka Kondo <[email protected]>
@youtalk youtalk requested a review from mitsudome-r November 25, 2024 04:47
Signed-off-by: Yutaka Kondo <[email protected]>
Copy link
Member

@mitsudome-r mitsudome-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@youtalk youtalk merged commit 4139127 into main Nov 25, 2024
17 checks passed
@youtalk youtalk deleted the autoware-base-image branch November 25, 2024 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:openadkit Issues or Features related to Open AD Kit tag:run-health-check Run health-check type:containers Docker containers, containerization of components, or container orchestration.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants