Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docker): inherit autoware-base images #5492

Merged
merged 9 commits into from
Nov 27, 2024
Merged

feat(docker): inherit autoware-base images #5492

merged 9 commits into from
Nov 27, 2024

Conversation

youtalk
Copy link
Member

@youtalk youtalk commented Nov 26, 2024

Description

This PR configured the Dockerfile to build using the autoware-base images introduced in #5476.

Tests performed

https://github.com/autowarefoundation/autoware/actions/runs/12041839421
https://github.com/autowarefoundation/autoware/actions/runs/12041840548

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
@youtalk youtalk self-assigned this Nov 26, 2024
@youtalk youtalk added type:containers Docker containers, containerization of components, or container orchestration. component:openadkit Issues or Features related to Open AD Kit tag:run-health-check Run health-check labels Nov 26, 2024
@youtalk youtalk marked this pull request as ready for review November 26, 2024 06:42
@youtalk youtalk requested a review from xmfcx November 26, 2024 06:42
@youtalk youtalk marked this pull request as draft November 27, 2024 01:06
Signed-off-by: Yutaka Kondo <[email protected]>
@youtalk youtalk marked this pull request as ready for review November 27, 2024 03:42
@youtalk youtalk merged commit 4148d65 into main Nov 27, 2024
25 checks passed
@youtalk youtalk deleted the use-base-image branch November 27, 2024 09:22
youtalk added a commit to youtalk/autoware that referenced this pull request Nov 29, 2024
* feat(docker): inherit `autoware-base`  images (autowarefoundation#5492)

* change run

Signed-off-by: Yutaka Kondo <[email protected]>

* use autoware-base images

Signed-off-by: Yutaka Kondo <[email protected]>

* update health-check

Signed-off-by: Yutaka Kondo <[email protected]>

* update load-env

Signed-off-by: Yutaka Kondo <[email protected]>

* update load-env

Signed-off-by: Yutaka Kondo <[email protected]>

* fix rebase

Signed-off-by: Yutaka Kondo <[email protected]>

* add build-args

Signed-off-by: Yutaka Kondo <[email protected]>

* fix hcl

Signed-off-by: Yutaka Kondo <[email protected]>

---------

Signed-off-by: Yutaka Kondo <[email protected]>

* chore(autoware.repos): fix `autoware.universe` and `autoware_launch` versions to `0.39.0` (autowarefoundation#5479)

* ci: update the pr template and add comment-on-pr workflow (autowarefoundation#5500)

Signed-off-by: M. Fatih Cırıt <[email protected]>

* ci(spell-check): switch the repository to autowarefoundation (autowarefoundation#5501)

Signed-off-by: M. Fatih Cırıt <[email protected]>

* ci(pre-commit-ansible): autoupdate (autowarefoundation#5217)

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions <[email protected]>

* ci(spell-check-diff): add explicit dict-packages (autowarefoundation#5503)

Signed-off-by: M. Fatih Cırıt <[email protected]>

* refactor(docker): fix `Dockerfile` indent (autowarefoundation#5495)

fix indent

Signed-off-by: Yutaka Kondo <[email protected]>

* feat(docker): update cleanup scripts (autowarefoundation#5497)

* update cleanup scripts

Signed-off-by: Yutaka Kondo <[email protected]>

* revert to ubuntu-22.04

Signed-off-by: Yutaka Kondo <[email protected]>

---------

Signed-off-by: Yutaka Kondo <[email protected]>

* ci(sync-files): make use of sync-files-templates repo (autowarefoundation#5504)

Signed-off-by: M. Fatih Cırıt <[email protected]>

---------

Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: M. Fatih Cırıt <[email protected]>
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: M. Fatih Cırıt <[email protected]>
Co-authored-by: awf-autoware-bot[bot] <94889083+awf-autoware-bot[bot]@users.noreply.github.com>
Co-authored-by: github-actions <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:openadkit Issues or Features related to Open AD Kit tag:run-health-check Run health-check type:containers Docker containers, containerization of components, or container orchestration.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants