refactor(lane_departure_checker): move member functions to util functions #9547
+97
−55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions Signed-off-by: kyoichi-sugahara <[email protected]>
kyoichi-sugahara
requested review from
mkuri and
zulfaqar-azmi-t4
as code owners
kyoichi-sugahara
added
the
tag:run-build-and-test-differential
github-actions
bot
added
the
component:control
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9547 +/- ##
==========================================
- Coverage 29.51% 29.50% -0.01%
==========================================
Files 1444 1450 +6
Lines 108528 108563 +35
Branches 41404 41400 -4
==========================================
+ Hits 32032 32036 +4
- Misses 73376 73405 +29
- Partials 3120 3122 +2
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
control/autoware_lane_departure_checker/src/lane_departure_checker_node/utils.cpp
Outdated
Show resolved
Hide resolved
Comment on lines
+177
to
+182
| for (const auto & route_lanelet : route_lanelets) { | ||
| const auto poly = route_lanelet.polygon2d().basicPolygon(); | ||
| if (!boost::geometry::disjoint(poly, footprint_hull)) { | ||
| candidate_lanelets.push_back(route_lanelet); | ||
| } | ||
| } |
There was a problem hiding this comment.
seems like a good place to use std::copy_if
…cker_node/utils.cpp Co-authored-by: Zulfaqar Azmi <[email protected]>
control/autoware_lane_departure_checker/src/lane_departure_checker_node/utils.cpp
Outdated
Show resolved
Hide resolved
…cker_node/utils.cpp Co-authored-by: Zulfaqar Azmi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
minor refactoring changes to improve testability and prepare the lane_departure_checker module for unit testing implementation. The changes are minimal and do not affect the core functionality.
createVehiclePassingAreas(),getCandidateLanelets()andcreateVehiclePassingAreas()fromLaneDepartureCheckerclass to utility functionscreateVehiclePassingAreasRelated links
Parent Issue:
How was this PR tested?
run psim
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.