-
Notifications
You must be signed in to change notification settings - Fork 657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lane_changing): improve computation of lane changing acceleration #9545
base: main
Are you sure you want to change the base?
feat(lane_changing): improve computation of lane changing acceleration #9545
Conversation
Signed-off-by: mohammad alqudah <[email protected]>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9545 +/- ##
==========================================
- Coverage 29.50% 29.50% -0.01%
==========================================
Files 1444 1446 +2
Lines 108519 108554 +35
Branches 41396 41401 +5
==========================================
+ Hits 32022 32029 +7
- Misses 73377 73407 +30
+ Partials 3120 3118 -2
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
planning/behavior_path_planner/autoware_behavior_path_lane_change_module/README.md
Outdated
Show resolved
Hide resolved
…nge_module/README.md Co-authored-by: Maxime CLEMENT <[email protected]>
Description
Currently when generating candidate lane change paths, we sample multiple longitudinal acceleration values, however for values below 0.0 (decelerating), it is only applied to the prepare phase, while min acceleration for lane changing phase is limited to 0.0, meaning we assume no deceleration during lane changing phase. And this behavior is not configurable.
Sometimes this assumption can result in not finding a safe candidate path near the terminal, specifically when there is a leading target lane object.
It is better to allow some deceleration during lane changing phase when approaching terminal to increase the chances of finding a safe candidate path.
Changes
Modified function
calc_lane_changing_acceleration
:lane_changing_decel_factor
Related links
Parent Issue:
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
ROS Parameter Changes
Additions and removals
lane_changing_decel_factor
double
0.5
Effects on system behavior
Increase chances of finding a safe candidate path near terminal when there is a leading target lane object.