Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lane_changing): improve computation of lane changing acceleration #9545

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mkquda
Copy link
Contributor

@mkquda mkquda commented Dec 3, 2024

Description

Currently when generating candidate lane change paths, we sample multiple longitudinal acceleration values, however for values below 0.0 (decelerating), it is only applied to the prepare phase, while min acceleration for lane changing phase is limited to 0.0, meaning we assume no deceleration during lane changing phase. And this behavior is not configurable.

Sometimes this assumption can result in not finding a safe candidate path near the terminal, specifically when there is a leading target lane object.

It is better to allow some deceleration during lane changing phase when approaching terminal to increase the chances of finding a safe candidate path.

Changes

Modified function calc_lane_changing_acceleration:

  • IF sampled longitudinal acceleration is negative, AND ego is near terminal, THEN return a ratio of sampled longitudinal acceleration determined by parameter lane_changing_decel_factor
  • IF sampled longitudinal acceleration is negative, AND ego is NOT near terminal, THEN return 0.0 (same as before)

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

ROS Parameter Changes

Additions and removals

Change type Parameter Name Type Default Value Description
Added lane_changing_decel_factor double 0.5 longitudinal deceleration factor during lane changing phase

Effects on system behavior

Increase chances of finding a safe candidate path near terminal when there is a leading target lane object.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Dec 3, 2024
Copy link

github-actions bot commented Dec 3, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@mkquda mkquda added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 3, 2024
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 29.50%. Comparing base (959e57b) to head (e77d6bf).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
..._path_lane_change_module/src/utils/calculation.cpp 25.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9545      +/-   ##
==========================================
- Coverage   29.50%   29.50%   -0.01%     
==========================================
  Files        1444     1446       +2     
  Lines      108519   108554      +35     
  Branches    41396    41401       +5     
==========================================
+ Hits        32022    32029       +7     
- Misses      73377    73407      +30     
+ Partials     3120     3118       -2     
Flag Coverage Δ *Carryforward flag
differential 22.13% <62.50%> (?)
total 29.50% <ø> (-0.01%) ⬇️ Carriedforward from cca0655

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 added the tag:deploy-docs Mark for deploy-docs action generation. (used-by-ci) label Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:deploy-docs Mark for deploy-docs action generation. (used-by-ci) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants