refactor(blind_spot): move util functions outside of class #9544
+428
−359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
component:planning
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
soblin
commented
Dec 3, 2024
| return half_lanelet; | ||
| } | ||
|
|
||
| lanelet::ConstLanelet generateExtendedAdjacentLanelet( |
There was a problem hiding this comment.
- same impl is as before
- check planner_param_.adjacent_extend_width is passed as before
|
|
||
| lanelet::ConstLanelet generateHalfLanelet( | ||
| const lanelet::ConstLanelet lanelet, const TurnDirection & turn_direction, | ||
| const double ignore_width_from_centerline) |
There was a problem hiding this comment.
- same impl as before
- check
planner_param_.ignore_width_from_centerlineis passed as before
| return new_lanelet; | ||
| } | ||
|
|
||
| lanelet::ConstLanelet generateExtendedOppositeAdjacentLanelet( |
There was a problem hiding this comment.
- same impl as before
- check if
planner_param_.opposite_adjacent_extend_widthis passed as before
soblin
force-pushed
the
test/blind-spot
branch
from
5e3e1d5
to
56ee998
Compare
yhisaki
approved these changes
Dec 3, 2024
soblin
force-pushed
the
test/blind-spot
branch
from
ff5b13e
to
19644fc
Compare
Signed-off-by: Mamoru Sobue <[email protected]>
Signed-off-by: Mamoru Sobue <[email protected]>
soblin
force-pushed
the
test/blind-spot
branch
from
19644fc
to
7cb25f4
Compare
soblin
added
the
tag:run-build-and-test-differential
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9544 +/- ##
==========================================
- Coverage 29.49% 29.48% -0.02%
==========================================
Files 1444 1452 +8
Lines 108530 108583 +53
Branches 41406 41409 +3
==========================================
Hits 32012 32012
- Misses 73397 73450 +53
Partials 3121 3121
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
move the member functions outside of class for adding unti tests
Related links
Parent Issue:
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.