Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autoware_ground_segmentation): remove unused function #9536

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

veqcc
Copy link
Contributor

@veqcc veqcc commented Dec 2, 2024

Description

Fixed cppcheck unusedFunction warning

perception/autoware_ground_segmentation/src/scan_ground_filter/grid.hpp:117:0: style: The function 'getPointNum' is never used. [unusedFunction]
  inline int getPointNum() const { return static_cast<int>(point_list_.size()); }

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@veqcc veqcc self-assigned this Dec 2, 2024
@github-actions github-actions bot added component:perception Advanced sensor data processing and environment understanding. (auto-assigned) tag:require-cuda-build-and-test labels Dec 2, 2024
Copy link

github-actions bot commented Dec 2, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@veqcc veqcc added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 2, 2024
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.49%. Comparing base (90fb05f) to head (9d14479).
Report is 18 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9536      +/-   ##
==========================================
- Coverage   29.50%   29.49%   -0.02%     
==========================================
  Files        1443     1443              
  Lines      108683   108653      -30     
  Branches    41540    41540              
==========================================
- Hits        32067    32044      -23     
+ Misses      73495    73489       -6     
+ Partials     3121     3120       -1     
Flag Coverage Δ *Carryforward flag
differential 13.86% <ø> (?)
total 29.49% <ø> (-0.02%) ⬇️ Carriedforward from 41c5956

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@badai-nguyen
Copy link
Contributor

LGTM but @technolojin just added this function. Did you have any intention when added it?

@technolojin
Copy link
Contributor

@badai-nguyen It was used during development, but it may removed in finalization. It is good to be removed.

Copy link
Contributor

@technolojin technolojin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@badai-nguyen badai-nguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@veqcc veqcc merged commit 8d9ca0e into autowarefoundation:main Dec 4, 2024
42 checks passed
@veqcc veqcc deleted the fix/unusedFunction2 branch December 4, 2024 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) tag:require-cuda-build-and-test tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants