-
Notifications
You must be signed in to change notification settings - Fork 657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(autoware_ground_segmentation): remove unused function #9536
Conversation
Signed-off-by: Ryuta Kambe <[email protected]>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9536 +/- ##
==========================================
- Coverage 29.50% 29.49% -0.02%
==========================================
Files 1443 1443
Lines 108683 108653 -30
Branches 41540 41540
==========================================
- Hits 32067 32044 -23
+ Misses 73495 73489 -6
+ Partials 3121 3120 -1
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
LGTM but @technolojin just added this function. Did you have any intention when added it? |
@badai-nguyen It was used during development, but it may removed in finalization. It is good to be removed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Fixed cppcheck
unusedFunction
warningRelated links
Parent Issue:
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.