feat(start_planner): add current lanes as member var #9518
+23
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielsanchezaran
requested review from
kosuke55,
kyoichi-sugahara,
soblin,
satoshi-ota,
shmpwk,
TomohitoAndo and
tkimura4
as code owners
github-actions
bot
added
component:planning
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
danielsanchezaran
force-pushed
the
feat/add-current-lanes-as-member-var
branch
from
6ed664a
to
d1ce2fd
Compare
github-actions
bot
removed
the
type:ci
danielsanchezaran
added
the
tag:run-build-and-test-differential
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9518 +/- ##
==========================================
- Coverage 29.52% 29.48% -0.04%
==========================================
Files 1441 1446 +5
Lines 108565 108624 +59
Branches 41490 41492 +2
==========================================
- Hits 32056 32030 -26
- Misses 73387 73475 +88
+ Partials 3122 3119 -3
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: tomoya.kimura <[email protected]>
… reduce code repetition Signed-off-by: Daniel Sanchez <[email protected]>
danielsanchezaran
force-pushed
the
feat/add-current-lanes-as-member-var
branch
from
d1ce2fd
to
c43d878
Compare
github-actions
bot
added
the
type:ci
kyoichi-sugahara
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Current lanelets are computed around 7-8 times in the code, by moving them as part of start plannerdata, we reduce code size and reduce possible errors. performance might improve very lightly.
Related links
Parent Issue:
How was this PR tested?
PSim
degradation tests: https://evaluation.tier4.jp/evaluation/reports/6780245d-af96-5548-b5f1-0727fc54310a?project_id=prd_jt
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.