fix(scenario_simulator_v2_adapter): remove invalid CHANGELOG.rst file #9501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esteve
requested review from
kyoichi-sugahara,
maxime-clem and
TakaHoribe
as code owners
esteve
added
the
run:build-and-test-differential
github-actions
bot
added
type:documentation
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9501 +/- ##
==========================================
- Coverage 29.49% 29.48% -0.02%
==========================================
Files 1444 1443 -1
Lines 108520 108467 -53
Branches 41389 41418 +29
==========================================
- Hits 32008 31980 -28
+ Misses 73393 73369 -24
+ Partials 3119 3118 -1
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
github-actions
bot
added
the
component:system
esteve
force-pushed
the
remove-invalid-changelog
branch
from
ec29522 to
3f5cc47
Compare
xmfcx
approved these changes
Nov 30, 2024
|
@xmfcx thanks for the review. @kyoichi-sugahara, @maxime-clem, @TakaHoribe could you approve this small change and merge this PR? Thanks. |
Signed-off-by: Esteve Fernandez <[email protected]>
esteve
force-pushed
the
remove-invalid-changelog
branch
from
3f5cc47 to
b9c2efc
Compare
github-actions
bot
removed
the
component:system
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A copy of the
CHANGELOG.rstfile fordiagnostic_converterwas added in #9180Its version and package name don't match the data in
package.xml. This is breaking builds in the buildfarm (see https://github.com/autowarefoundation/autoware-deb-packages/actions/runs/12031082816/job/33539936241?pr=105)This PR simply removes that file.
Related links
Parent Issue:
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.