Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(autoware_lidar_transfusion): added a warning if we are dropping voxels #9486

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

knzo25
Copy link
Contributor

@knzo25 knzo25 commented Nov 27, 2024

Description

If the input pointcloud generates more voxels than the model that handle, we are currently clipping the number of voxels.
If that happens, we should notify users so they can consider increasing the model parameters.

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@knzo25 knzo25 self-assigned this Nov 27, 2024
@github-actions github-actions bot added component:perception Advanced sensor data processing and environment understanding. (auto-assigned) tag:require-cuda-build-and-test labels Nov 27, 2024
Copy link

github-actions bot commented Nov 27, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@knzo25 knzo25 marked this pull request as ready for review November 27, 2024 08:53
Copy link
Contributor

@amadeuszsz amadeuszsz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amadeuszsz amadeuszsz added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 4, 2024
@knzo25 knzo25 enabled auto-merge (squash) December 4, 2024 08:00
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 29.49%. Comparing base (560654f) to head (133ab39).

Files with missing lines Patch % Lines
...autoware_lidar_transfusion/lib/transfusion_trt.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9486      +/-   ##
==========================================
- Coverage   29.49%   29.49%   -0.01%     
==========================================
  Files        1446     1447       +1     
  Lines      108528   108545      +17     
  Branches    41407    41410       +3     
==========================================
+ Hits        32009    32013       +4     
- Misses      73400    73413      +13     
  Partials     3119     3119              
Flag Coverage Δ *Carryforward flag
differential 4.63% <0.00%> (?)
total 29.49% <ø> (ø) Carriedforward from 560654f

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) tag:require-cuda-build-and-test tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants