-
Notifications
You must be signed in to change notification settings - Fork 657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(autoware_lidar_transfusion): added a warning if we are dropping voxels #9486
base: main
Are you sure you want to change the base?
chore(autoware_lidar_transfusion): added a warning if we are dropping voxels #9486
Conversation
Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9486 +/- ##
==========================================
- Coverage 29.49% 29.49% -0.01%
==========================================
Files 1446 1447 +1
Lines 108528 108545 +17
Branches 41407 41410 +3
==========================================
+ Hits 32009 32013 +4
- Misses 73400 73413 +13
Partials 3119 3119
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Description
If the input pointcloud generates more voxels than the model that handle, we are currently clipping the number of voxels.
If that happens, we should notify users so they can consider increasing the model parameters.
Related links
Parent Issue:
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.