Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(perception_online_evaluator): use tier4_metric_msgs instead of diagnostic_msgs #9485

Conversation

ktro2828
Copy link
Contributor

@ktro2828 ktro2828 commented Nov 27, 2024

Description

This PR changes to apply tier4_metric_msgs to perception_online_evaluator, instead of diagnostic_msgs.

Related links

Parent Issue:

Private Links:

How was this PR tested?

Notes for reviewers

None.

Interface changes

Topic changes

Modifications

Version Topic Type Topic Name Message Type Description
Old Pub /metrics diagnostic_msgs::msg::DiagnosticArray Diagnostic information about perception accuracy.
New Pub /metrics tier4_metric_msgs::msg::MetricArray Metric information about perception accuracy.

Effects on system behavior

None.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:evaluator Evaluation tools for planning, localization etc. (auto-assigned) labels Nov 27, 2024
Copy link

github-actions bot commented Nov 27, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@ktro2828
Copy link
Contributor Author

ktro2828 commented Nov 27, 2024

@kosuke55 I have a one question about tier4_metric_msgs::msg::Metric.
Which value should I set to unit in this case? (Currently, I set m for now...)

According to this PR, it seems there are some kind of values are set to unit, such as empty, type and SI unit.

@ktro2828 ktro2828 changed the title refactor: use tier4_metric_msgs instead of diagnostic_msgs refactor(perception_online_evaluator): use tier4_metric_msgs instead of diagnostic_msgs Nov 27, 2024
@xtk8532704
Copy link
Contributor

@kosuke55 I have a one question about tier4_metric_msgs::msg::Metric. Which value should I set to unit in this case? (Currently, I set m for now...)

According to this PR, it seems there are some kind of values are set to unit, such as empty, type and SI unit.

Now that we don't have a restriction on the unit, you can set up anything easy to understand in unit. In the future, we may define it in detail like how monitoringmessages-ros2 do, but for now it's just an unused identifier.

@ktro2828 ktro2828 marked this pull request as ready for review November 29, 2024 03:12
@ktro2828 ktro2828 requested a review from xtk8532704 November 29, 2024 03:47
@xtk8532704
Copy link
Contributor

ping @kosuke55

@ktro2828 ktro2828 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 29, 2024
@ktro2828
Copy link
Contributor Author

I will open after fixing to pass unit testings.

@ktro2828 ktro2828 marked this pull request as draft November 29, 2024 05:45
Signed-off-by: ktro2828 <[email protected]>
@ktro2828 ktro2828 marked this pull request as ready for review November 29, 2024 09:28
@ktro2828
Copy link
Contributor Author

I fixed CI failures, and set unit to empty string for now because various units are included such as m, rad...

@xtk8532704 @kosuke55 Could check it?

@ktro2828 ktro2828 force-pushed the refactor/perception-evaluator/metric-msgs branch from eb479ed to 69b1ea5 Compare November 29, 2024 10:12
Copy link

codecov bot commented Nov 29, 2024

Codecov Report

Attention: Patch coverage is 95.65217% with 1 line in your changes missing coverage. Please review.

Project coverage is 29.49%. Comparing base (b5c98ef) to head (ef51453).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...evaluator/src/perception_online_evaluator_node.cpp 95.65% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9485   +/-   ##
=======================================
  Coverage   29.49%   29.49%           
=======================================
  Files        1444     1446    +2     
  Lines      108520   108546   +26     
  Branches    41389    41395    +6     
=======================================
+ Hits        32008    32018   +10     
- Misses      73393    73408   +15     
- Partials     3119     3120    +1     
Flag Coverage Δ *Carryforward flag
differential 17.64% <95.65%> (?)
total 29.48% <ø> (-0.02%) ⬇️ Carriedforward from 7b7db7a

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ktro2828 ktro2828 enabled auto-merge (squash) December 2, 2024 15:08
@ktro2828 ktro2828 merged commit 214c9b7 into autowarefoundation:main Dec 2, 2024
32 checks passed
@ktro2828 ktro2828 deleted the refactor/perception-evaluator/metric-msgs branch December 3, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:evaluator Evaluation tools for planning, localization etc. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants