-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(perception_online_evaluator): use tier4_metric_msgs instead of diagnostic_msgs #9485
refactor(perception_online_evaluator): use tier4_metric_msgs instead of diagnostic_msgs #9485
Conversation
Signed-off-by: ktro2828 <[email protected]>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Now that we don't have a restriction on the |
evaluator/perception_online_evaluator/src/perception_online_evaluator_node.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: ktro2828 <[email protected]>
ping @kosuke55 |
I will open after fixing to pass unit testings. |
Signed-off-by: ktro2828 <[email protected]>
I fixed CI failures, and set unit to empty string for now because various units are included such as m, rad... @xtk8532704 @kosuke55 Could check it? |
Signed-off-by: ktro2828 <[email protected]>
eb479ed
to
69b1ea5
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9485 +/- ##
=======================================
Coverage 29.49% 29.49%
=======================================
Files 1444 1446 +2
Lines 108520 108546 +26
Branches 41389 41395 +6
=======================================
+ Hits 32008 32018 +10
- Misses 73393 73408 +15
- Partials 3119 3120 +1
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Description
This PR changes to apply
tier4_metric_msgs
toperception_online_evaluator
, instead ofdiagnostic_msgs
.Related links
Parent Issue:
Private Links:
How was this PR tested?
Notes for reviewers
None.
Interface changes
Topic changes
Modifications
/metrics
diagnostic_msgs::msg::DiagnosticArray
/metrics
tier4_metric_msgs::msg::MetricArray
Effects on system behavior
None.