chore(freespace_planning_algorithms): update for A* python wrapper #8890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
component:planning
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
TakumIto
force-pushed
the
feat/astar_wrapper_distance_function
branch
3 times, most recently
from
333efc0 to
1e25b48
Compare
TakumIto
requested review from
kosuke55,
TakaHoribe and
takayuki5168
as code owners
kosuke55
approved these changes
Oct 10, 2024
kosuke55
reviewed
Oct 10, 2024
| double getDistanceToObstacle(const std::string & pose_byte) | ||
| { | ||
| rclcpp::SerializedMessage serialized_msg; | ||
| static constexpr size_t message_header_length = 8u; |
There was a problem hiding this comment.
how to know this value 8u?
There was a problem hiding this comment.
I imitated the code of another feature.
https://github.com/autowarefoundation/autoware_common/blob/7c55915cb435c17f24f78dd9b9f28fa269609671/tmp/lanelet2_extension_python/src/utility.cpp#L136
It uses the same header length 8u for all messages. But I'm sorry, I have no idea how it has been decided.
added 3 commits
October 16, 2024 16:07
Signed-off-by: Takumi Ito <[email protected]>
Signed-off-by: Takumi Ito <[email protected]>
Signed-off-by: Takumi Ito <[email protected]>
kosuke55
force-pushed
the
feat/astar_wrapper_distance_function
branch
from
521f76e to
d2226de
Compare
kosuke55
added
the
run:build-and-test-differential
|
This pull request has been automatically marked as stale because it has not had recent activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update for A* python wrapper to use the getDistanceToObstacle() function.
Related links
This PR is initially prepared for A* parameter tuning tool autoware_tools PR#120. But, not only for it but also for other applications using python wrapper.
How was this PR tested?
Evaluator: https://evaluation.tier4.jp/evaluation/reports/733ee4d0-e5fc-5308-8520-fdbaf61526f8?project_id=prd_jt
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.