Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pyproject.toml for PyTorch versions #107

Merged
merged 5 commits into from
Jun 19, 2024
Merged

Conversation

Neeratyoy
Copy link
Contributor

No description provided.

@Neeratyoy
Copy link
Contributor Author

@eddiebergman @karibbov are the tests passsing adequate a check for this to be merged?

@eddiebergman
Copy link
Contributor

Good enough given what we've got I would say, if it causes issues. Then these issues should have an associated test so we can catch them in the future.

@Neeratyoy
Copy link
Contributor Author

@eddiebergman
Do you wanna merge or I go with it?

`torchvision` - `torch` compatability
@karibbov
Copy link
Collaborator

karibbov commented Jun 18, 2024

Updating torch > 2.0.0 requires torchvision >= 0.16. Then, we get an error from import torchvision. Anyone can decrypt the traceback?

@karibbov
Copy link
Collaborator

karibbov commented Jun 18, 2024

Turns out AttributeError: 'int' object has no attribute 'nodes'
originates from here. When the dimension of the nested list -
graphs is 2 _nested_graphs.ndims sometimes returns 3 if the graphs in the dimension 2 are consistent, which causes the if clause to be taken and graphs list to be corrupted.
Made a short fix to it, that doesn't seem to break any tests

@Neeratyoy
Copy link
Contributor Author

That's a great catch!

@Neeratyoy Neeratyoy merged commit 9a1079c into master Jun 19, 2024
13 checks passed
@Neeratyoy Neeratyoy deleted the torch-dep-patch-1 branch June 19, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants