-
Couldn't load subscription status.
- Fork 18
Abstract class for data generation #450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
JaGeo
wants to merge
2
commits into
main
Choose a base branch
from
abstract_classes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| from abc import ABC, abstractmethod | ||
| from dataclasses import dataclass | ||
| from pathlib import Path | ||
|
|
||
| from atomate2.forcefields.jobs import ForceFieldRelaxMaker, ForceFieldStaticMaker | ||
| from jobflow import Flow, Maker | ||
| from pydantic import BaseModel, Field | ||
| from pymatgen.core import Composition, Structure | ||
| from pymatgen.io.ase import MSONAtoms | ||
|
|
||
|
|
||
| class DataGenDoc(BaseModel): | ||
| """The inputs used to run this job.""" | ||
|
|
||
| database_dir: Path | None = Field(None, description="Address to xyz file") | ||
| # or find another way to store the db | ||
| database: list[MSONAtoms] | None = Field(None, description="list of Atoms objects") | ||
|
|
||
|
|
||
| @dataclass | ||
| class AbstractDataGenFlow(Maker, ABC): | ||
| """ | ||
| Base class for data generation workflows. | ||
| """ | ||
|
|
||
| static_maker: ForceFieldStaticMaker = ( | ||
| None # labels the data, we might need to use partial here, or we pass mlip configs differently | ||
| ) | ||
| isolated_static_maker: ForceFieldStaticMaker = None # labels isolated atom | ||
| relax_maker: ForceFieldRelaxMaker = ( | ||
| None ## helps with optimization to get data close to minimum (dft or ml model), could be optional | ||
| ) | ||
| config: dict = None | ||
|
|
||
| def make( | ||
| self, | ||
| input_structures: list[Structure] = None, | ||
| input_compositions: list[Composition] = None, | ||
| ) -> Flow: | ||
| flow = self.data_gen_flow() | ||
| return Flow( | ||
| flow.jobs, | ||
| output=DataGenDoc( | ||
| database_dir=flow.output["database_path"], | ||
| database=flow.output["database"], | ||
| ), | ||
| ) | ||
|
|
||
| @abstractmethod | ||
| def data_gen_flow(self) -> Flow: | ||
| pass | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could be it informative to also store some stats on database itself? Like for example diversity of structures, volumes, spacegroups as additional information ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds like a good idea but we should always have the use cases in mind.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it could be helpful for active learning?