Abstract class for data generation #450
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JaGeo, thanks for this! should we define the parameters for static_maker, isolated_static_maker, and relax_maker also in the config? That is, we could centralize all parameter definitions in config.yaml. |
naik-aakash
reviewed
Oct 11, 2025
|
|
||
| database_dir: Path | None = Field(None, description="Address to xyz file") | ||
| # or find another way to store the db | ||
| database: list[MSONAtoms] | None = Field(None, description="list of Atoms objects") |
There was a problem hiding this comment.
Could be it informative to also store some stats on database itself? Like for example diversity of structures, volumes, spacegroups as additional information ?
There was a problem hiding this comment.
Sounds like a good idea but we should always have the use cases in mind.
There was a problem hiding this comment.
Maybe it could be helpful for active learning?
|
@YuanbinLiu yes, ideally this can be part of the config |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started with a first abstract class for a prototype "DataGenerationMaker". The interface is highly similar to our current RSSMaker.
This affects #443
I would be happy to hear comments about this, @YuanbinLiu and @naik-aakash .
It is surely not perfect yet and getting the PhononMaker into this shape might be some work. The Doc also needs to go into "schema.py" However, I believe it will be worth it in the long run. (PhononMaker will be on my todo)