fix: Controller container property assignment #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
@evansims when it will be released? |
|
Hi, @alebedev80; we're currently in a code freeze until after the holidays. |
|
@evansims last release is broken. why not to release fix asap? |
|
@alebedev80 As a company policy, we are not permitted to cut releases during a code freeze, as the team is on vacation for the holidays and is unable to provide support. The problematic release was already purged from Packagist to avoid bugged installs. Once our code freeze is lifted, I will cut a release containing the fix as soon as possible. |
evansims
pushed a commit
that referenced
this pull request
Jan 4, 2024
### Changes Fix syntax typo in the previous code change in `AuthenticationController::__construct()` ### References #178 #179 https://github.com/auth0/symfony/actions/runs/7279226624/job/19835136156 https://github.com/auth0/symfony/actions/runs/7279226624/job/19835137264 ### Testing [ ] This change adds test coverage [ ] This change has been tested on the latest version of Symfony ### Checklist [x] I have read the [Auth0 general contribution guidelines](https://github.com/auth0/open-source-template/blob/master/GENERAL-CONTRIBUTING.md) [x] I have read the [Auth0 Code of Conduct](https://github.com/auth0/open-source-template/blob/master/CODE-OF-CONDUCT.md) [ ] All existing and new tests complete without errors
evansims
changed the title
Merged
evansims
added a commit
that referenced
this pull request
Jan 9, 2024
**Fixed** - Syntax typo in AuthenticationController::__construct() [\#180](#180) ([mkilmanas](https://github.com/mkilmanas)) - Controller container property assignment [\#179](#179) ([mkilmanas](https://github.com/mkilmanas))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Please describe both what is changing and why this is important. Include:
References
[#178]
Testing
Previously Symfony (6.4) app container building (cache:clear) was throwing a fatal error, now it's not.
This change adds test coverage
This change has been tested on the latest version of Symfony
Checklist
I have read the Auth0 general contribution guidelines
I have read the Auth0 Code of Conduct
All existing and new tests complete without errors