fix: Syntax typo in AuthenticationController::__construct()

[mkilmanas]

Changes

Fix syntax typo in the previous code change in AuthenticationController::__construct()

References

#178
#179
https://github.com/auth0/symfony/actions/runs/7279226624/job/19835136156
https://github.com/auth0/symfony/actions/runs/7279226624/job/19835137264

Testing

[ ] This change adds test coverage

[ ] This change has been tested on the latest version of Symfony

Checklist

[x] I have read the Auth0 general contribution guidelines

[x] I have read the Auth0 Code of Conduct

[ ] All existing and new tests complete without errors

[mkilmanas]

@evansims I'm a little lost at how the CI / GitHub Actions are setup and used around here.

1. I have noticed this particular issue when I checked the build on the main branch after my previous PR was merged -> https://github.com/auth0/symfony/actions/runs/7279226624/job/19835137264
2. However it seems that the same checks have passed while it was still on the PR (i.e. not merged) -> https://github.com/auth0/symfony/actions/runs/7276254927

So I suspect that builds on PRs do not actually include the to-be-merged code and run only on the base branch.

Moreover, I see this PR did not even get the actions run to validate the fix - any reason for that?

And lastly, now build on main branch is failing for some completely unrelated problems (i.e. nowhere close to the modified code), so I suspect a change in the version of libs running those tests. Which brings us to my recent observation - when I tried to do composer install on the main branch today, it failed and warned me that composer.lock is out of sync with composer.json with many items being in the json, but not lock, or having versions locked which are outside of ranges permitted by json, and so on. So I suspect that GH Actions might be also using depencencies loaded via composer update rather than composer install, which may lead to instabilities like the one currently on main branch.

[evansims]

So I suspect that builds on PRs do not actually include the to-be-merged code and run only on the base branch.

The build break is due to an upstream breaking change with PHPCS; not anything to do on our end.

Moreover, I see this PR did not even get the actions run to validate the fix - any reason for that?

As a security measure, all PRs must be approved manually by our team before they're run. Considering this change was one character, I opted to skip that and merge without running them.

And lastly, now build on main branch is failing for some completely unrelated problems (i.e. nowhere close to the modified code), so I suspect a change in the version of libs running those tests.

See above; this is due to an upstream breaking change. Nothing to do with changes on our end, or how we do things.

Which brings us to my recent observation - when I tried to do composer install on the main branch today, it failed and warned me that composer.lock is out of sync with composer.json with many items being in the json, but not lock, or having versions locked which are outside of ranges permitted by json, and so on.

We don't commit any lockfiles.

So I suspect that GH Actions might be also using depencencies loaded via composer update rather than composer install, which may lead to instabilities like the one currently on main branch.

No, it doesn't.