-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated automated release to support manual trigger #1212
Merged
Merged
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
80153f4
Read version from .version file and add get_release_notes
frederikprijck 6da251b
Bring back exit 1 when tag exists
frederikprijck 9ee710d
Avoid creating a tag manually
frederikprijck 0b78278
Drop automated trigger for now to test manual trigger
frederikprijck fc2f806
Update get-release-notes to use github-scripts
frederikprijck 213709b
Merge branch 'main' into feat/automated-release
frederikprijck File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
name: Return the release notes extracted from the PR body | ||
|
||
# | ||
# Returns the release notes from the content of a pull request linked to a release branch. It expects the branch name to be in the format release/vX.Y.Z, release/X.Y.Z, release/vX.Y.Z-beta.N. etc. | ||
# | ||
# TODO: Remove once the common repo is public. | ||
# | ||
inputs: | ||
version : | ||
required: true | ||
repo_name: | ||
required: false | ||
repo_owner: | ||
required: true | ||
token: | ||
required: true | ||
|
||
runs: | ||
using: composite | ||
|
||
steps: | ||
- id: get_release_notes | ||
shell: bash | ||
run: | | ||
RELEASE_PR_BRANCH="release/$VERSION" | ||
API_URL="https://api.github.com/repos/$REPO_OWNER/$REPO_NAME/pulls" | ||
RELEASE_NOTES=$(curl -G \ | ||
-H "Accept: application/json" \ | ||
-H "Authorization: token $GITHUB_TOKEN" \ | ||
--data-urlencode "state=all" \ | ||
--data-urlencode "head=$REPO_OWNER:$RELEASE_PR_BRANCH" \ | ||
"$API_URL" | jq -r ".[0].body" | ||
) | ||
{ | ||
echo 'RELEASE_NOTES<<EOF' | ||
echo $RELEASE_NOTES | ||
echo 'EOF' | ||
} >> $GITHUB_ENV | ||
|
||
env: | ||
GITHUB_TOKEN: ${{ inputs.token }} | ||
REPO_OWNER: ${{ inputs.repo_owner }} | ||
REPO_NAME: ${{ inputs.repo_name }} | ||
VERSION: ${{ inputs.version }} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,13 @@ | ||
{ | ||
"files": { | ||
"src/version.ts": [], | ||
"README.md": ["{MAJOR}.{MINOR}"], | ||
"FAQ.md": ["{MAJOR}.{MINOR}.{PATCH}"] | ||
".version": [], | ||
"README.md": [ | ||
"{MAJOR}.{MINOR}" | ||
], | ||
"FAQ.md": [ | ||
"{MAJOR}.{MINOR}.{PATCH}" | ||
] | ||
}, | ||
"postbump": "npm run docs" | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
v2.1.2 |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Temporarily removing the automated trigger on PR close, will bring back one manual trigger has been verified. But if we keep this trigger, if everything works as expected we can not even get to testing the manual trigger.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to add back the PR merge trigger now to verify that it works once the release PR is merged?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I was thinking to do a manual release. Then bring it back. Else we have no way to test the manual trigger.
We can then use the automated to cut a release for Auth0-React to include the latest SPA-JS.