Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated automated release to support manual trigger #1212

Merged
merged 6 commits into from
Dec 11, 2023

Conversation

frederikprijck
Copy link
Member

@frederikprijck frederikprijck commented Dec 11, 2023

Updating the release process to avoid depending on the context of the current PR, but instead rely on the branch based on the version found in the .version file, restoring behavior like we had when we published through Circle CI.

  • Add a .version file and configure Ship CLI to automatically bump the version
  • Update get-version to read from the .version file instead of the branch name.
  • Add an action to get the release notes instead of relying on the current PR associated with the workflow trigger.
  • No longer create a tag manually, but rely on softprops/action-gh-release to create the tag when we create the GitHub release.

Note: Because the release-notes are multiline, I was unable to use GITHUB_OUTPUT, but had to resort to GITHUB_ENV instead, exposing the release notes as an environment variable.

@@ -16,7 +17,7 @@ env:

jobs:
release:
if: github.event.pull_request.merged && startsWith(github.event.pull_request.head.ref, 'release/')
if: github.event_name == 'workflow_dispatch'
Copy link
Member Author

@frederikprijck frederikprijck Dec 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Temporarily removing the automated trigger on PR close, will bring back one manual trigger has been verified. But if we keep this trigger, if everything works as expected we can not even get to testing the manual trigger.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to add back the PR merge trigger now to verify that it works once the release PR is merged?

Copy link
Member Author

@frederikprijck frederikprijck Dec 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I was thinking to do a manual release. Then bring it back. Else we have no way to test the manual trigger.

We can then use the automated to cut a release for Auth0-React to include the latest SPA-JS.

@frederikprijck frederikprijck marked this pull request as ready for review December 11, 2023 09:54
@frederikprijck frederikprijck requested a review from a team as a code owner December 11, 2023 09:54
@frederikprijck frederikprijck enabled auto-merge (squash) December 11, 2023 11:16
@frederikprijck frederikprijck merged commit 0dda1ab into main Dec 11, 2023
16 checks passed
@frederikprijck frederikprijck deleted the feat/automated-release branch December 11, 2023 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants