Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer PR number for group instead of ref #1147

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Conversation

ewanharris
Copy link
Contributor

@ewanharris ewanharris commented Sep 20, 2023

Changes

There are a few PRs that are stuck waiting for Browerstack tests to run, when checking that action we can see the following Browserstack: .github#L1 Canceling since a higher priority waiting request for 'Browserstack-refs/heads/main' exists, and this group key is consistent across all 3 PRs.

I believe this is because we use pull_request_target where the ref is the base branch (branch the PR is targeting), by preferring the PR number where possible we ensure it's unique for PRs.

Usual caveat applies of not being able to thoroughly test until merged, but based on other repos across GitHub I think usage of nested objects that may not exist is safe.

References

Testing

  • This change adds unit test coverage
  • This change adds integration test coverage
  • This change has been tested on the latest version of the platform/language

Checklist

@ewanharris ewanharris requested a review from a team as a code owner September 20, 2023 16:35
@ewanharris ewanharris temporarily deployed to internal September 20, 2023 16:35 — with GitHub Actions Inactive
@ewanharris ewanharris temporarily deployed to internal September 20, 2023 16:35 — with GitHub Actions Inactive
@ewanharris ewanharris temporarily deployed to internal September 20, 2023 16:35 — with GitHub Actions Inactive
@frederikprijck frederikprijck added this pull request to the merge queue Sep 20, 2023
Merged via the queue into main with commit cedbd50 Sep 20, 2023
16 checks passed
@frederikprijck frederikprijck deleted the ci/browserstack-grou branch September 20, 2023 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants