Prefer PR number for group instead of ref #1147
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
There are a few PRs that are stuck waiting for Browerstack tests to run, when checking that action we can see the following
Browserstack: .github#L1 Canceling since a higher priority waiting request for 'Browserstack-refs/heads/main' exists
, and this group key is consistent across all 3 PRs.I believe this is because we use
pull_request_target
where the ref is the base branch (branch the PR is targeting), by preferring the PR number where possible we ensure it's unique for PRs.Usual caveat applies of not being able to thoroughly test until merged, but based on other repos across GitHub I think usage of nested objects that may not exist is safe.
References
Testing
Checklist