Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefer PR number for group name #276

Merged
merged 3 commits into from
Sep 22, 2023
Merged

Prefer PR number for group name #276

merged 3 commits into from
Sep 22, 2023

Conversation

ewanharris
Copy link
Contributor

Changes

Ensure the group key for browserstack tests is unique due to the use of pull_request_target

References

auth0/auth0-spa-js/pull/1147

Testing

  • This change adds unit test coverage
  • This change adds integration test coverage
  • This change has been tested on the latest version of the platform/language

Checklist

@ewanharris ewanharris requested a review from a team as a code owner September 21, 2023 10:19
@ewanharris ewanharris temporarily deployed to internal September 21, 2023 10:19 — with GitHub Actions Inactive
@ewanharris ewanharris temporarily deployed to internal September 21, 2023 10:19 — with GitHub Actions Inactive
@ewanharris ewanharris temporarily deployed to internal September 21, 2023 10:19 — with GitHub Actions Inactive
@ewanharris ewanharris enabled auto-merge (squash) September 21, 2023 10:20
@ewanharris ewanharris merged commit 32e0a0e into main Sep 22, 2023
18 checks passed
@ewanharris ewanharris deleted the ewanharris-patch-1 branch September 22, 2023 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frederikprijck frederikprijck frederikprijck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ewanharris @frederikprijck