Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: upgraded ruby/setup-ruby action from version v1.152.0 to v1.178.0 #214

Merged
merged 4 commits into from
Jun 20, 2024
Merged

ci: upgraded ruby/setup-ruby action from version v1.152.0 to v1.178.0 #214

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
73f0d47
ci: upgraded ruby/setup-ruby action from version v1.152.0 to v1.178.0
desusai7 Jun 19, 2024
5406743
ci: added codecov token
desusai7 Jun 19, 2024
e50ad16
ci: added authorize step for executing steps job to protect codecov t…
desusai7 Jun 20, 2024
f619a12
ci: added environment to test job
desusai7 Jun 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/actions/setup/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ runs:
shell: bash

- name: Set up Ruby
uses: ruby/setup-ruby@250fcd6a742febb1123a77a841497ccaa8b9e939
uses: ruby/setup-ruby@0cde4689ba33c09f1b890c1725572ad96751a3fc # pinned to version v1.178.0
with:
bundler-cache: true
cache-version: 1
Expand Down
11 changes: 11 additions & 0 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,17 @@ concurrency:
cancel-in-progress: ${{ github.ref != 'refs/heads/master' }}

jobs:
authorize:
name: Authorize
environment: ${{ github.event.pull_request.head.repo.fork && 'external' || 'internal' }}
runs-on: ubuntu-latest
steps:
- run: true

test:
needs: authorize # Require approval before running on forked pull requests
name: Test on ${{ matrix.platform.os }} using Xcode ${{ matrix.xcode }}
environment: ${{ github.event.pull_request.head.repo.fork && 'external' || 'internal' }}
runs-on: macos-13

env:
Expand Down Expand Up @@ -52,6 +61,8 @@ jobs:
- name: Upload coverage report
if: ${{ matrix.platform.os == 'iOS' }}
uses: codecov/codecov-action@ab904c41d6ece82784817410c45d8b8c02684457
with:
token: ${{ secrets.CODECOV_TOKEN }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the job uses a secret, we used to require an 'authorize' check to avoid running the job on third party PRs –so as to avoid leaking the secrets: https://github.com/auth0/auth0-flutter/blob/main/.github/workflows/main.yml#L175

I'd suggest checking with the team how you prefer to handle the usage of CI secrets going forward.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, will add authorize step for now and will discuss internally within the team as well on handling secrets going forward.


test-package:
name: Test Swift package using Xcode ${{ matrix.xcode }}
Expand Down