ci: upgraded ruby/setup-ruby action from version v1.152.0 to v1.178.0 #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Widcket
previously approved these changes
Jun 19, 2024
Widcket
reviewed
Jun 19, 2024
| @@ -52,6 +52,8 @@ jobs: | |||
| - name: Upload coverage report | |||
| if: ${{ matrix.platform.os == 'iOS' }} | |||
| uses: codecov/codecov-action@ab904c41d6ece82784817410c45d8b8c02684457 | |||
| with: | |||
| token: ${{ secrets.CODECOV_TOKEN }} | |||
There was a problem hiding this comment.
If the job uses a secret, we used to require an 'authorize' check to avoid running the job on third party PRs –so as to avoid leaking the secrets: https://github.com/auth0/auth0-flutter/blob/main/.github/workflows/main.yml#L175
I'd suggest checking with the team how you prefer to handle the usage of CI secrets going forward.
There was a problem hiding this comment.
Got it, will add authorize step for now and will discuss internally within the team as well on handling secrets going forward.
Widcket
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📋 Changes
3.0.7📎 References
https://github.com/auth0/SimpleKeychain/actions/runs/9581919093/job/26419770960