feat: added support for visionOS platform #859
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…handle breaking changes
…g network requests
… opening up a new tab in safari
…versions which support visionOS
Widcket
reviewed
Jul 4, 2024
Auth0/MobileWebAuth.swift
Outdated
| func presentationAnchor(for session: ASWebAuthenticationSession) -> ASPresentationAnchor { | ||
| if let windowScene = UIApplication.shared()?.connectedScenes.first(where: { $0.activationState == .foregroundActive }) as? UIWindowScene { | ||
| return windowScene.windows.last(where: \.isKeyWindow) ?? ASPresentationAnchor() | ||
| } else { |
There was a problem hiding this comment.
Nit: the else is not necessary here because of the early return on L24.
There was a problem hiding this comment.
Agreed, modified it accordingly
Widcket
reviewed
Jul 4, 2024
Comment on lines
15
to
16
| static var authentication = Auth0.authentication(clientId: clientId, domain: domain) | ||
| static var validatorContext = IDTokenValidatorContext(issuer: URL.httpsURL(from: domain).absoluteString, |
There was a problem hiding this comment.
Could these be static constants?
Widcket
reviewed
Jul 4, 2024
Comment on lines
500
to
502
| beforeEach { | ||
|
|
||
| } |
There was a problem hiding this comment.
Not necessary, removed it now
Widcket
reviewed
Jul 4, 2024
| stub(condition: isToken(Domain) && hasAtLeast(["refresh_token": RefreshToken, key: value]) && hasHeader(key, value: "bar")) { _ in | ||
| return authResponse(accessToken: NewAccessToken, idToken: NewIdToken, refreshToken: NewRefreshToken, expiresIn: ExpiresIn) | ||
| } | ||
| NetworkStub.addStub(condition: { $0.isToken(Domain) && $0.hasAtLeast(["refresh_token": RefreshToken, key: value])}, response: authResponse(accessToken: NewAccessToken, idToken: NewIdToken, refreshToken: NewRefreshToken, expiresIn: ExpiresIn)) |
There was a problem hiding this comment.
This seems to be missing a hasHeader check.
There was a problem hiding this comment.
Yes, thank you for pointing it out, added it back now
Widcket
reviewed
Jul 4, 2024
Auth0Tests/NetworkStub.swift
Outdated
| typealias RequestResponse = (URLRequest) -> (Data?, URLResponse?, Error?) | ||
|
|
||
| struct NetworkStub { | ||
| static var stubs: [(condition: RequestCondition, response: RequestResponse)] = [] |
There was a problem hiding this comment.
Should this be private(set)?
There was a problem hiding this comment.
yes, made its setter private now
Widcket
reviewed
Jul 4, 2024
Auth0Tests/Responses.swift
Outdated
| func apiSuccessResponse(json: [AnyHashable: Any] = [:]) -> RequestResponse { | ||
| return { request in | ||
| let data = try! JSONSerialization.data(withJSONObject: json, options: []) | ||
| let response = HTTPURLResponse(url: request.url!, statusCode: APISuccessStatusCode, httpVersion: nil, headerFields: APIResponseHeaders) |
There was a problem hiding this comment.
Should we force-unwrap the response here as well?
There was a problem hiding this comment.
Yes, missed it, added it now
Widcket
approved these changes
Jul 5, 2024
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📋 Changes
feat: added support for visionOS platform
ASProvider.swift,Auth0WebAuth.swift&MobileWebAuth.swift.Quick&Nimbleto latest versions in order to supportvisionOS.sharedExamplesfromQuicktoBehaviorpattern as its the recommended, and at the same time we are facing issues with it ontvOSplatform.cwlPreConditionTestingpackage viaSPMas latest versions ofQuick&Nimbleneeded it.OHHTTPStubsdoes not supportvisionOSplatform yet.Xcode 14andSwiftversions[5.7, 5.8]as they came along with Xcode 14 and the minimum version of swift required now is5.9✅ Checks
📎 References
Auth0.swift#823
🎯 Testing
ASWebAuthenticationSession, and not onSFSafariViewControlleras we are not supporting it as user agent on visionOS platform as its opening as a new tab in the safari app instead of a pop-up in the app.