Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

follow up latest storybook version #1

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

shuieryin
Copy link

No description provided.

@MichaelDimmitt
Copy link

What version of node are you using?

I assume you have storybook working locally?
can you remove package-lock.json from .gitignore

and add it to this pr or push it up in a new branch??

#2 - other people are having a trouble running the project locally.

I cant approve and merge the pr but it will help to close #2

@MichaelDimmitt
Copy link

MichaelDimmitt commented May 23, 2021

Confirmed, this fixed #2 ! 🎉
Thanks @shuieryin

version of npm and node that I used:
node: v12.22.1
npm: 6.14.12

  1. Storybook was updated!
  2. also node-sass version for master is currently pointed to 4.11.0 which is no longer a valid release on node-sass 🤦‍♂️
    so when you try to install, it will fail if you do not already have it on your computer.

This saved me so much time trying to debug myself.

@shuieryin
Copy link
Author

Confirmed, this fixed #2 ! 🎉
Thanks @shuieryin

version of npm and node that I used:
node: v12.22.1
npm: 6.14.12

  1. Storybook was updated!
  2. also node-sass version for master is currently pointed to 4.11.0 which is no longer a valid release on node-sass 🤦‍♂️
    so when you try to install, it will fail if you do not already have it on your computer.

This saved me so much time trying to debug myself.

oh wow that was almost 1.5 yrs ago I already forgot what did I do 😂

glad the PRs helped!

@audriusnavickasDB
Copy link
Owner

Sorry guys, I had abandoned this place after the article was released. So the node version used was described in .nvmrc file.

As this is quite out dated and there are multiple common approaches, new and faster tools now out there in the world, I will try on my free time to update this repository to represent the most popular ones. Will add some readme files with guidelines what can be done, how and why, but it will take some time. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants