Package lock + webpack upgrades from pr#1 #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelDimmitt
changed the title
|
With the current approach my understanding is that we need to install multiple packages like @audnavlib/button, @audnavlib/button-group. Instead, how can we install the entire library(components-library) and then import the components like import Button from 'components-library/button' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Confirmed, this fixed #2 ! 🎉
Thanks @shuieryin
version of npm and node that I used:
node: v12.22.1
npm: 6.14.12
#1 added the following:
so when you try to install, it will fail if you do not already have it on your computer.
This saved me so much time trying to debug myself.
This pr adds a package-lock to help future users.
as long as node-sass does not delete a release again. 🙅♂️