Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

698 ldp patch import resource one by one #987

Merged
merged 62 commits into from
Jun 27, 2022
Merged

698 ldp patch import resource one by one #987

merged 62 commits into from
Jun 27, 2022

Conversation

nikoPLP
Copy link
Contributor

@nikoPLP nikoPLP commented Jun 5, 2022 •
edited by srosset81

Le service de mirroir fonctionne. vous voulez le tester?
merci de lire la doc ici avant de tester:
website/docs/middleware/mirror.md

this PR implements/fixes #517 #849 #850 #698

Breaking changes

A new http://semapps.org/mirror graph must be configured, and data must be migrated.
Please read the guide here

@nikoPLP
creating Mirror graph, protecting LDP actions against Mirror data
df1b1f4
@nikoPLP
fixing bug with root container not having his children as sub container
5a37663
@nikoPLP
working void service for localData, need to test for mirror data
9e0daac
@nikoPLP
creating Mirror graph, protecting LDP actions against Mirror data
9907f66
@nikoPLP
Merge branch '849_mirror_service' of ssh://github.com/assemblee-virtu…
776255c 
…elle/semapps into 849_mirror_service
@nikoPLP
first version of mirror service, brutaly mirrors everything everytime…
6627e10 
… the middleware starts. no activityPub subscription yet
@nikoPLP
starting the registry service asynchroniously again, so it can play w…
63471b2 
…ell with webacl service
@nikoPLP
working void service for localData, need to test for mirror data
b81cb13
@nikoPLP
creating Mirror graph, protecting LDP actions against Mirror data
8de986a
@nikoPLP
first version of mirror service, brutaly mirrors everything everytime…
c734b4a 
… the middleware starts. no activityPub subscription yet
@nikoPLP
starting the registry service asynchroniously again, so it can play w…
2f9819c 
…ell with webacl service
@nikoPLP
Merge branch '849_mirror_service' of ssh://github.com/assemblee-virtu…
97dafaf 
…elle/semapps into 849_mirror_service
@nikoPLP
allowing multiple void#class in each partition
b3108d9
@nikoPLP
logging fdone properly at Mirror service startup. errors do not crash…
d913f9c 
… the server
@nikoPLP
ldp.mirror service become independant mirror service. automatic creat…
4269ba1 
…ion of Actor relay and its webfinger
@nikoPLP
FOLLOW of the relay actor once the mirror is done
3d32d03
@nikoPLP
updateBot working well for create, update, delete. permission changes…
3538c50 
… is not tested yet
@nikoPLP
fix bug race condition on OIDC issuer retrieval
de26b7d
@nikoPLP
ldp.container.isEmpty action
2e2ad02
@nikoPLP
fixing the bug of first level containers not attached to root container
585b489
@nikoPLP
UpdateBot: changing permissions sends activities to followers. it works
4f86bbf
@nikoPLP
docker service for migration + initial documentation
ab92036
@nikoPLP
prettier
d574741
@nikoPLP
working void service for localData, need to test for mirror data
3f98975
@nikoPLP
creating Mirror graph, protecting LDP actions against Mirror data
872a7f6
@nikoPLP
first version of mirror service, brutaly mirrors everything everytime…
f2647fa 
… the middleware starts. no activityPub subscription yet
@nikoPLP
starting the registry service asynchroniously again, so it can play w…
2970094 
…ell with webacl service
@nikoPLP
allowing multiple void#class in each partition
99e4363
@nikoPLP
logging fdone properly at Mirror service startup. errors do not crash…
93690b2 
… the server
@nikoPLP
ldp.mirror service become independant mirror service. automatic creat…
2046418 
…ion of Actor relay and its webfinger
srosset81
srosset81 requested changes Jun 20, 2022
View reviewed changes
Copy link
Contributor

@srosset81 srosset81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci !! Pas mal de commentaire ci-dessous, désolé pour la longueur mais la PR est conséquente ! :-P
J'ai testé l'endpoint VOID, le miroir en local, ainsi que l'import des données uniques via PATCH.
Sinon problème de migration comme dit en privé.
Fait un git pull car j'ai dû harmoniser les versions des packages SemApps afin que le yarn link fonctionne correctement.

src/middleware/packages/ldp/services/container/actions/get.js Outdated Show resolved Hide resolved
src/middleware/packages/ldp/services/container/actions/patch.js Outdated Show resolved Hide resolved
src/middleware/packages/ldp/services/container/actions/patch.js Outdated Show resolved Hide resolved
src/middleware/packages/ldp/services/container/actions/patch.js Outdated Show resolved Hide resolved
src/middleware/packages/ldp/services/registry/index.js Show resolved Hide resolved
src/middleware/packages/ldp/services/void/index.js Outdated Show resolved Hide resolved
src/middleware/packages/ldp/services/void/index.js Outdated Show resolved Hide resolved
src/middleware/packages/ldp/services/void/index.js Outdated Show resolved Hide resolved
src/middleware/packages/ldp/services/void/index.js Outdated Show resolved Hide resolved
src/middleware/packages/ldp/services/container/actions/patch.js Outdated Show resolved Hide resolved
@srosset81 srosset81 mentioned this pull request Jun 20, 2022
Merged
@nikoPLP
fix bug migration
4a3b8bf
@nikoPLP
Merge branch '698_ldp_patch_import_resource_one_by_one' of ssh://gith…
cf75d68 
…ub.com/assemblee-virtuelle/semapps into 698_ldp_patch_import_resource_one_by_one
@nikoPLP nikoPLP self-assigned this Jun 23, 2022
@nikoPLP
Copy link
Contributor Author

nikoPLP commented Jun 23, 2022 •
edited

j'ai essayé de répondre a toutes vos questions et de modifier ce qui était modifiable.
Le code mis a jour est dipo dans la branche !
@srosset81 la prochaine etape serait de tester l'integration avec le frontend ?

@srosset81
Copy link
Contributor

Merci @nikoPLP !
J'ai répondu à tes commentaires. Lundi je teste tes modifications en vue de merger ! :-)
Concernant le frontend, oui il y a encore pas mal de boulot ! Surtout dans l'interprétation de l'endpoint VOID et la modifications des requêtes SPARQL afin qu'elles prennent en compte les données miroirs. J'ai ajouté la gestion du PATCH sur container dans la PR #992.

@nikoPLP
Copy link
Contributor Author

nikoPLP commented Jun 24, 2022

modifications des requêtes SPARQL afin qu'elles prennent en compte les données miroirs

Si tu veux parler des actions ldp.resource.get et ldp.container.get, j ái deja fait le code. Elles retournent bien les resources en mirroir.

Si tu veux parler de requete Sparql autres, qui sont lancées depuis le client, alors en effet, il faut rajouter un UNION avec le graph mirroir.

@nikoPLP
Copy link
Contributor Author

nikoPLP commented Jun 24, 2022 •
edited

Je viens d'implementer ce matin la derniere tache qui m'incombe, a savoir #771

Je l'ai mis dans la meme branche car ca fait partie du meme projet pour moi, et je voudrais bien que ce soit validé et mergé en meme temps.

Encore un peu plus de code a reviewer et tester pour toi, @srosset81

@srosset81
Copy link
Contributor

Si tu veux parler de requete Sparql autres, qui sont lancées depuis le client, alors en effet, il faut rajouter un UNION avec le graph mirroir.

Oui je parle de ça.

srosset81
srosset81 requested changes Jun 27, 2022
View reviewed changes
src/middleware/packages/ldp/services/container/actions/patch.js Outdated Show resolved Hide resolved
src/middleware/packages/mirror/index.js Outdated Show resolved Hide resolved
src/middleware/packages/mirror/index.js Outdated Show resolved Hide resolved
src/middleware/packages/void/index.js Outdated Show resolved Hide resolved
src/middleware/packages/void/index.js Outdated Show resolved Hide resolved
src/middleware/packages/void/README.md Show resolved Hide resolved
src/middleware/packages/ldp/services/resource/actions/get.js Outdated Show resolved Hide resolved
website/docs/middleware/ldp/index.md Show resolved Hide resolved
@srosset81 srosset81 mentioned this pull request Jun 27, 2022
Closed
@srosset81 srosset81 merged commit d23bf25 into next Jun 27, 2022
@srosset81 srosset81 deleted the 698_ldp_patch_import_resource_one_by_one branch June 27, 2022 14:13
@srosset81 srosset81 mentioned this pull request Jun 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonLouvet simonLouvet simonLouvet left review comments

@srosset81 srosset81 srosset81 approved these changes

Assignees

@srosset81 srosset81

@nikoPLP nikoPLP

Labels
breaking changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nikoPLP @srosset81 @simonLouvet