Include ArtemisCloud icon in the ClusterServiceVersion #1052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brusdev
reviewed
Nov 18, 2024
There was a problem hiding this comment.
@solipsistadventurer thanks for your contribution, to fix the PR checks you can execute the following steps:
- regenerate bundle manifests and commit changes, i.e.
make bundle && git commit --amend --all --no-edit - squash all commits into one commit and prepend the commit message with the issue number, i.e.
git reset --soft HEAD~2 && git commit -a -m '[#1049] Include ArtemisCloud icon in the ClusterServiceVersion' - push changes to your remote origin, i.e.
git push -f origin main
solipsistadventurer
force-pushed
the
main
branch
from
e851e03 to
c59de69
Compare
|
@solipsistadventurer I regenerated the bundle manifests because yours were generated with a different operator-sdk version. I'll merge your contribution after the execution of the PR checks. |
|
So I noticed. I was already wondering whether I should do something about that. Thank you for your help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is in reference to the issue raised here - https://github.com/artemiscloud/activemq-artemis-operator/issues/1049
This change is cosmetic in nature and does not affect Operator functionality.
Currently no icon is included in the ClusterServiceVersion definition. As a result, if the Operator is deployed in OpenShift OLM the "broken link" icon is displayed in the OpenShift web console under
OperatorHubandInstalled Operators.This change solves the issue. As a result, OLM will display the ArtemisCloud icon.
The ArtemisCloud GitHub avatar icon (200x200px PNG image) was used for this change.
I have tested this change manually on OpenShift v4.14.33
Notes:
.spec.iconentries are defined manually - see https://docs.openshift.com/container-platform/4.17/operators/operator_sdk/osdk-generating-csvs.html#osdk-manually-defined-csv-fields_osdk-generating-csvsbundle/manifests/activemq-artemis-operator.clusterserviceversion.yamlis probably generated automatically fromconfig/manifests/bases/activemq-artemis-operator.clusterserviceversion.yaml. However, I am not sure how often this file is actually generated. Therefore I have introduced the change in both files.