Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include icon in the ClusterServiceVersion #1049

Closed
solipsistadventurer opened this issue Nov 13, 2024 · 3 comments
Closed

Include icon in the ClusterServiceVersion #1049

solipsistadventurer opened this issue Nov 13, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@solipsistadventurer
Copy link
Contributor

solipsistadventurer commented Nov 13, 2024 •
edited
Loading

This feature request is entirely cosmetic and does not affect Operator functionality.

Currently no icon is included in the ClusterServiceVersion definition. The entry under .spec.icon contains empty strings. As a result, when the Operator is deployed to OLM, this looks very ugly in the OperatorHub:

image

Describe the feature
Introduce appropriate values for the spec.icon entry. OperatorHub displays a nice icon.
@solipsistadventurer solipsistadventurer added the enhancement New feature or request label Nov 13, 2024
@brusdev
Copy link
Contributor

brusdev commented Nov 14, 2024

This enhancement LGTM. The ArtemisCloud GitHub avatar icon could work: https://avatars.githubusercontent.com/u/50884737?s=200&v=4

@solipsistadventurer are you planning to contribute by creating a pull request?

@solipsistadventurer solipsistadventurer mentioned this issue Nov 18, 2024
Merged
@solipsistadventurer
Copy link
Contributor Author

@brusdev I will be happy to contribute.
See https://github.com/artemiscloud/activemq-artemis-operator/pull/1052 and the remarks therein.
Thanks for your great work.

brusdev pushed a commit to brusdev/activemq-artemis-operator that referenced this issue Nov 19, 2024
@solipsistadventurer @brusdev
[arkmq-org#1049] Include ArtemisCloud icon in the ClusterServiceVersion
31ddd0c
brusdev pushed a commit that referenced this issue Nov 19, 2024
@solipsistadventurer @brusdev
[#1049] Include ArtemisCloud icon in the ClusterServiceVersion
d7656ad
@brusdev
Copy link
Contributor

brusdev commented Nov 19, 2024

Resolved by artemiscloud@d7656ad

@solipsistadventurer thanks for your contribution

@brusdev brusdev closed this as completed Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brusdev @solipsistadventurer