CommandDispatcher の統一的なテレメの提供 #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meltingrabbit
force-pushed
the
feature/cdis_tlm_mgr
branch
from
1e90eb5
to
14353c9
Compare
meltingrabbit
changed the base branch from
feature/fix_url_of_docs
to
feature/change_ret_type_of_app_initializer
meltingrabbit
force-pushed
the
feature/cdis_tlm_mgr
branch
7 times, most recently
from
16e3021
to
97fcddc
Compare
meltingrabbit
force-pushed
the
feature/change_ret_type_of_app_initializer
branch
from
6521bc2
to
8164836
Compare
Base automatically changed from
feature/change_ret_type_of_app_initializer
to
develop
July 20, 2023 08:53
meltingrabbit
force-pushed
the
feature/cdis_tlm_mgr
branch
from
2bc273d
to
db5dbf1
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Examples/mobc/src/src_user/Test/test/src_core/TlmCmd/test_command_dispatcher_manager.py
Outdated
Show resolved
Hide resolved
meltingrabbit
force-pushed
the
feature/cdis_tlm_mgr
branch
from
db5dbf1
to
4af200e
Compare
Examples/mobc/src/src_user/Test/test/src_core/TlmCmd/test_command_dispatcher_manager.py
Outdated
Show resolved
Hide resolved
meltingrabbit
force-pushed
the
feature/cdis_tlm_mgr
branch
from
957c92f
to
4248722
Compare
examples/mobc/src/src_user/Test/test/src_core/TlmCmd/test_command_dispatcher_manager.py
Show resolved
Hide resolved
meltingrabbit
changed the title
|
今の MOBC で使いたい機能を実装しました．レビューください @ToshiAki64 |
ToshiAki64
reviewed
Jul 27, 2023
examples/mobc/src/src_user/Settings/TlmCmd/command_dispatcher_manager_params.h
Outdated
Show resolved
Hide resolved
ToshiAki64
approved these changes
Jul 28, 2023
Closed
sksat
added a commit
that referenced
this pull request
Oct 17, 2023
sksat
added a commit
that referenced
this pull request
Oct 27, 2023
sksat
added a commit
that referenced
this pull request
Oct 30, 2023
sksat
added a commit
that referenced
this pull request
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
MOBC には様々な sub OBC やコンポーネント用の CIDS が存在する．
CDIS のテレメトリはノミナルではみず，なにかのアノマリ時に確認する．
そのようなテレメを各 CDIS ごとに設定するのはメンテコストが高すぎるので，統一的な tlm を core が提供する．
なお，このために CDIS の初期化関数のインターフェースを変更している
Issue
検証結果
追加した pytest が通った
影響範囲
各 user の CIDS の初期化関数が変更される