-
-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple archnavbar versions #322
Comments
I am planning on switching to the arch-common-style one, and that version should also become responsive somehow. The plan is to first switch plain css to scss so I can get rid of cssmin which isn't even maintained anymore. We'll have to figure out if a git submodule checkout can be used for the common-style and research if django-sass is good enough to generate css |
Hi, can I help with this? I work with sass/scss in my day job. The way I see it you could also just host the arch-common-style CSS somewhere and then While we're at it, what about my PR? I'd probably have to rewrite it in scss, right? |
Well, the minimalist solution is to build archlinux-common-style with make and sassc. As far as I understand, django-sass does not have any benefits here since archlinux-common-style is not a Django app and we're not trying to switch the whole archweb to SASS (yet?). |
I don't see any benefit in the minimalist solution, I'd rather switch to djang-sass to take advantage of something which using all the common styles which it adds for colors etc. |
Ok, turns out django-sass has pros and cons: So relying on an arch package like |
Truns out django-sass uses libsass which is deprecated in favor of https://sass-lang.com/dart-sass which we package! |
Why do we have this and this?
Also, we should probably use arch-common-style to generate the navbar style. (Didn't check yet if there is actually a visual difference...)
The text was updated successfully, but these errors were encountered: