Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Integrate archlinux-common-style #494

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lahwaacz
Copy link
Contributor

@lahwaacz lahwaacz commented Mar 10, 2024

This depends on the following currently open merge requests:

When they are merged, the URL of the archlinux_common_style git submodule must be updated to upstream.

This will close #322 eventually.

This depends on the following currently open merge requests:

- https://gitlab.archlinux.org/archlinux/archlinux-common-style/-/merge_requests/9
- https://gitlab.archlinux.org/archlinux/archlinux-common-style/-/merge_requests/10

When they are merged, the URL of the `archlinux_common_style` git
submodule must be updated to upstream.
@jelly
Copy link
Member

jelly commented Apr 28, 2024

Sorry for checking this out so late, this basically switches it to use the css files from archlinux-common-styles no? Afaik Django does not handle sass?

@lahwaacz
Copy link
Contributor Author

Basically, yes, but more - with those merge requests for archlinux-common-style, the following would be taken from the external repo:

  • the navbar's HTML (as a Django template)
  • CSS for the navbar
  • Arch logo and icons

As for SASS, I have not managed to solve this part nicely yet. I found several projects with different approaches to the actual SASS backend, Django integration, and maintenance status. But all of them seem to focus on "live SASS builds" for development, which we specifically do not need for integrating an external project. We need to chat about this sometime 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple archnavbar versions
2 participants