Responsive Layout and Navbar from archlinux-common-style
#382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This tag is essential for a mobile friendly layout. See https://developer.mozilla.org/en-US/docs/Mozilla/Mobile/Viewport_meta_tag for more info.
The markup is added before the actual archnavbarlist to make it possible to select said list via the CSS sibling selector depending on hamburger state/class. Note that this commit removes the minium body width of 650px.
A new JavaScript file base.js is introduced and included in the base template so the hamburger button will work on every page.
- Make navigation bar stick to top on mobile. - Increase font size and spacing of navigation entries on mobile and increase their clickable area. - Expanded mobile navigation now spans the entire height.
It makes more sense for footer and devnavbar to be siblings of content, and not children. Also, this step makes it way easier to properly layout everything using flexbox instead of the outdated float mechanism.
- Layout switches arrangement of content depending on screen width using flexbox - Enable word-breaking for news articles. This is necessary because long words like directory paths might otherwise overflow on small screen widths. - The contents of the packages page are in correct order but there are still fixed widths which mess up the layout on small mobile devices.
This is to prevent the headlines from overlapping with the article timestamp.
- Every nav-sidebar items needs to be wrapped in a container to make proper styling possible. - nav-siderbar items will appear in columns of 2 or 3 depending on available screen width on mobile.
This way the navbar content won't span the entire screen width on wide monitors.
Table will be reformatted on mobile devices following the technique described here: https://css-tricks.com/responsive-data-tables/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is #255 rebased and with the navbar replaced by the one from
archlinux-common-stylevia a git submodule. Currently that still links to my branch but once the pull request is closed, I will update itI am not sure about the margin on the left and right side of the desktop version. Should it stay like it is right now, should it be removed just from the navbar, or should it be completely removed? I would keep it like it is right now.
Closes #322 #255 #212