Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added footer with licensing information #194

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Added footer with licensing information #194

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3580736
Add footer
lucabtz Sep 22, 2021
42ac147
footer: add source code link
lucabtz Sep 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions tracker/static/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,10 +118,13 @@ select {
}

#page_footer {
font-size: 0.9em;
margin: 0 auto;
font-size: 0.75em;
margin: 10px auto 20px auto;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use em / rem for marging.

text-align: center;
width: 95%;
}

#page_footer p {
margin: 0;
}

h1 {
Expand Down
24 changes: 24 additions & 0 deletions tracker/templates/base.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,5 +47,29 @@
{%- endwith -%}
{%- block content -%}{%- endblock %}
</div>
<div id="page_footer">
<p>
Copyright © 2002-2021
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, we don't have to update this every year manually in archweb we have something like:

templates/base.html:            <p>Copyright © 2002-{% now "Y" %} <a href="mailto:[email protected]"

So a jinja template variable should contain the current year.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line and the line below contains an extraneous space at the end of the line

<a href="mailto:[email protected]" title="Contact Judd Vinet">Judd Vinet</a>,
<a href="mailto:[email protected]" title="Contact Aaron Griffin">Aaron Griffin</a> and
<a href="mailto:[email protected]" title="Contact Levente Polyák">Levente Polyák</a>.
</p>

<p>
The Arch Linux name and logo are recognized
<a href="https://wiki.archlinux.org/title/DeveloperWiki:TrademarkPolicy" title="Arch Linux Trademark Policy">trademarks</a>.
Some rights reserved.
</p>

<p>
The registered trademark Linux® is used pursuant to a sublicense from LMI,
the exclusive licensee of Linus Torvalds, owner of the mark on a world-wide basis.
</p>

<p>
Arch Security Tracker is licensed under the terms of the MIT License,
<a href="https://github.com/archlinux/arch-security-tracker" target="_blank" title="Arch Security Tracker source code">source code</a>.
</p>
</div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything should be tab indented here, see our .editorconfig file.

</body>
</html>
2 changes: 1 addition & 1 deletion tracker/templates/todo.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
<p class="icon">{{ smiley }}</p>
<pre class="text">nothing to do
Yippie!</pre>
<div>
</div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ideally this would be a separate commit in this PR

{%- else %}
<h1>Todo Lists</h1>
{%- endif %}
Expand Down