Added footer with licensing information #194
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jelly
requested changes
Sep 26, 2021
| @@ -47,5 +47,29 @@ | |||
| {%- endwith -%} | |||
| {%- block content -%}{%- endblock %} | |||
| </div> | |||
| <div id="page_footer"> | |||
| <p> | |||
| Copyright © 2002-2021 | |||
There was a problem hiding this comment.
Ideally, we don't have to update this every year manually in archweb we have something like:
templates/base.html: <p>Copyright © 2002-{% now "Y" %} <a href="mailto:[email protected]"
So a jinja template variable should contain the current year.
| @@ -47,5 +47,29 @@ | |||
| {%- endwith -%} | |||
| {%- block content -%}{%- endblock %} | |||
| </div> | |||
| <div id="page_footer"> | |||
| <p> | |||
| Copyright © 2002-2021 | |||
There was a problem hiding this comment.
This line and the line below contains an extraneous space at the end of the line
| Arch Security Tracker is licensed under the terms of the MIT License, | ||
| <a href="https://github.com/archlinux/arch-security-tracker" target="_blank" title="Arch Security Tracker source code">source code</a>. | ||
| </p> | ||
| </div> |
There was a problem hiding this comment.
everything should be tab indented here, see our .editorconfig file.
| @@ -7,7 +7,7 @@ | |||
| <p class="icon">{{ smiley }}</p> | |||
| <pre class="text">nothing to do | |||
| Yippie!</pre> | |||
| <div> | |||
| </div> | |||
There was a problem hiding this comment.
ideally this would be a separate commit in this PR
jelly
reviewed
Sep 26, 2021
| font-size: 0.9em; | ||
| margin: 0 auto; | ||
| font-size: 0.75em; | ||
| margin: 10px auto 20px auto; |
|
Sorry for my late reply will look into it asap |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added footer with licensing information solving #175