Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixing modal height by removing min-content #36589

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

brayn003
Copy link
Contributor

@brayn003 brayn003 commented Sep 27, 2024

Description

min-content css property is behaving weirdly in the latest update of the chrome browser

Fixes #36586

Automation

/ok-to-test tags="@tag.Git"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/11084506553
Commit: a888acf
Cypress dashboard.
Tags: @tag.Git
Spec:


Sat, 28 Sep 2024 14:34:20 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

Summary by CodeRabbit

  • Style
    • Removed the minimum height constraint from the modal body, allowing for more flexible vertical space allocation in the modal display.

@brayn003 brayn003 requested a review from a team as a code owner September 27, 2024 10:07
Copy link
Contributor

coderabbitai bot commented Sep 27, 2024

Walkthrough

This pull request introduces a modification to the StyledModalBody component by removing the min-height: min-content; CSS style declaration. This change impacts the visual rendering of the modal body, specifically altering its minimum height constraint, which may affect the accessibility of elements within the modal.

Changes

File Change Summary
app/client/src/pages/Editor/gitSync/Tabs/GitConnectionV2/index.tsx Removed min-height: min-content; from StyledModalBody component.

Assessment against linked issues

Objective Addressed Explanation
The gif tutorial in the GIT config modal is going out of screen bounds (#[36586])

Possibly related PRs

  • fix: fixing cta for git import modal #36364: This PR modifies the nextStepText object within the GitConnectionV2 component, indicating a direct connection in terms of changes made to the component's structure and functionality.

Suggested labels

Bug, UX Improvement, Medium, IDE Product, IDE Pod, ok-to-test

Suggested reviewers

  • ankitakinger
  • hetunandu

In the modal where gifs do sway,
A change was made to save the day.
No more bounds, let content flow,
With CTAs now in easy tow.
A little tweak, a simple fix,
Enhancing UX, a clever mix! 🎉


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between e6cd973 and a888acf.

📒 Files selected for processing (1)
  • app/client/src/pages/Editor/gitSync/Tabs/GitConnectionV2/index.tsx (0 hunks)
💤 Files not reviewed due to no reviewable changes (1)
  • app/client/src/pages/Editor/gitSync/Tabs/GitConnectionV2/index.tsx

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added Bug Something isn't working Git Platform Issues related to the git & the app platform Git Product Issues related to version control product Medium Issues that frustrate users due to poor UX Needs Triaging Needs attention from maintainers to triage Production Regressed Scenarios that were working before but have now regressed labels Sep 27, 2024
@brayn003
Copy link
Contributor Author

/build-deploy-preview

Copy link

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/11068721310.
Workflow: On demand build Docker image and deploy preview.
skip-tests: . env: .
PR: 36589.
recreate: .

Copy link

Deploy-Preview-URL: https://ce-36589.dp.appsmith.com

@brayn003 brayn003 added the ok-to-test Required label for CI label Sep 28, 2024
@brayn003 brayn003 merged commit 138cb79 into release Sep 30, 2024
48 checks passed
@brayn003 brayn003 deleted the fix/css-min-content-chrome branch September 30, 2024 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Git Platform Issues related to the git & the app platform Git Product Issues related to version control product Medium Issues that frustrate users due to poor UX Needs Triaging Needs attention from maintainers to triage ok-to-test Required label for CI Production Regressed Scenarios that were working before but have now regressed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: the gif tutorial in the GIT config modal is going out of screen bounds
2 participants