Skip to content

Commit

Permalink
fix: fixing modal height by removing min-content (#36589)
Browse files Browse the repository at this point in the history
## Description
min-content css property is behaving weirdly in the latest update of the
chrome browser

Fixes #36586

## Automation

/ok-to-test tags="@tag.Git"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/11084506553>
> Commit: a888acf
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11084506553&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Git`
> Spec:
> <hr>Sat, 28 Sep 2024 14:34:20 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Style**
- Removed the minimum height constraint from the modal body, allowing
for more flexible vertical space allocation in the modal display.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
  • Loading branch information
brayn003 authored Sep 30, 2024
1 parent 5995e42 commit 138cb79
Showing 1 changed file with 0 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ const StyledModalBody = styled(ModalBody)`
overflow-y: initial;
display: flex;
flex-direction: column;
min-height: min-content;
max-height: calc(
100vh - 200px - 32px - 56px - 44px
); // 200px offset, 32px outer padding, 56px footer, 44px header
Expand Down

0 comments on commit 138cb79

Please sign in to comment.